Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[reconfig] Do not respawn node sync process #4724

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

lxfind
Copy link
Contributor

@lxfind lxfind commented Sep 20, 2022

Node sync process only runs on fullnode, while reconfiguration only happens on a validator.

@mystenmark
Copy link
Contributor

mystenmark commented Sep 20, 2022

reconfiguration only happens on a validator

Ok, this was my bad - I thought that nodes would follow the same reconfig process as validators when the epoch changes. If they won't, we certainly don't need this. But we will need an analogous function that fullnodes run when they switch to a new epoch.

Also, there is a piece that we do need to re-start after reconfig, which is the creation of NodeSyncState (here: https://github.com/MystenLabs/sui/blob/main/crates/sui-core/src/authority_active.rs#L286) - that piece does run on validators and will have to be re-created or otherwise reconfigured, since it holds an AuthorityAggregator and Committee.

But that's for another PR.

@lxfind lxfind merged commit aff89ae into main Sep 20, 2022
@lxfind lxfind deleted the no-node-sync-process-reconfig branch September 20, 2022 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants