Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit a better error when shared locks have not been set #4772

Merged
merged 2 commits into from
Sep 26, 2022

Conversation

mystenmark
Copy link
Contributor

No description provided.

@mystenmark mystenmark changed the title Emit a better error when shared locks have not be set Emit a better error when shared locks have not been set Sep 23, 2022
Copy link
Contributor

@lxfind lxfind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also find SharedObjectLockNotSetObject a strange error name. Maybe SharedObjectLockNotSetError?

@mystenmark mystenmark force-pushed the mlogan-shared-object-lock-error branch from 8151d91 to eaa88a8 Compare September 26, 2022 16:00
@mystenmark mystenmark enabled auto-merge (squash) September 26, 2022 16:01
@mystenmark mystenmark merged commit 71a96f6 into main Sep 26, 2022
@mystenmark mystenmark deleted the mlogan-shared-object-lock-error branch September 26, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants