[2/x][dev-inspect] Add authority end-point #6651
Conversation
tnowacki
requested review from
awelc,
patrickkuo,
sblackshear,
oxade,
gegaowp and
Jordan-Mysten
| } | ||
|
|
||
| #[derive(Clone, Serialize, Deserialize, JsonSchema)] | ||
| pub struct SuiExecutionResult { |
There was a problem hiding this comment.
@gegaowp or @Jordan-Mysten, not sure if you have feedback on the result here? I used SuiTypeTag with the BCS bytes of the value, but I'm not sure if something else would be easier to use.
There was a problem hiding this comment.
are mutable_reference_outputs objects, if so is there a way we can map the values to objects, or arguments in case there can be mutations around the same SuiTypeTag?
SuiTypeTag for the type of return values sgtm, thanks for the quick move!
There was a problem hiding this comment.
They could be anything, since this lets you call anything.
For example:
fun bump(counter: &mut u64, amount: u64) { *counter = *counter + u64 }
So in this case, you would get mutable_reference_outputs with (0, /* some bytes */, TypeTag::u64)
crates/sui-core/src/authority.rs
Outdated
| transaction_digest: TransactionDigest, | ||
| ) -> Result<DevInspectResults, anyhow::Error> { | ||
| let (gas_status, input_objects) = | ||
| transaction_input_checker::check_transaction_input(&self.database, &transaction) |
There was a problem hiding this comment.
From what I can tell this implies that the transaction needs a valid gas object, and this still verifies the object ownership but for dev inspect we want to bypass those checks
There was a problem hiding this comment.
We do yeah. I can try to fix that in this PR. I basically just want to check that all the objects exist. Would be nice to just strait up remove the gas logic too, but not sure if that is feasible. Any ideas?
There was a problem hiding this comment.
I wonder if we can make gas_payment on the transaction an Option<ObjectRef>, and just enforce it to be some for non dev-inspect transactions?
There was a problem hiding this comment.
A good suggestion, which gives me an idea! We are also looking at making gas_payment be a vector of ObjectRef (for a different work stream). Once we do that, we can make gas_payment optionally empty for the dev-inspect case? (though it might be tricky for the execution engine)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
tnowacki
force-pushed
the
di-messages
branch
from
111ac29
to
517c97a
Compare
- Add dev_inspect_transction entry point on the authority - Added new result type for dev inspect
tnowacki
force-pushed
the
di-messages
branch
from
517c97a
to
ec4f028
Compare
Follow-up to #6538 that is blocked by move-language/move#728.
Putting this up initially to get feedback on the result type.