Add dev-inspect-txn to RPC and SDK #7008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
sblackshear
approved these changes
Dec 23, 2022
amnn
reviewed
Dec 23, 2022
There was a problem hiding this comment.
Leaving a more detailed review -- most of the comments are not urgent so don't block the PR for them if this needs to go out urgently, but note the one about batch transactions always being dev inspect now. Maybe I've misunderstood what that code does, but it seemed not right to me.
|
@amnn Thanks for the detailed review and great feedback! I've addressed them in the last pushed commit |
666lcz
added a commit
that referenced
this pull request
Dec 23, 2022
Same as #6998 but - fixed typescript types - Relax RPC restriction for calling non-entry functions Co-authored-by: Ge Gao <106119108+gegaowp@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #6998 but