Decouple AuthorityTemporaryStore and AuthorityStore
#801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lxfind
requested review from
huitseeker,
velvia,
sblackshear,
gdanezis and
lavindir
gdanezis
approved these changes
Mar 12, 2022
| Some(o) => match &o.data { | ||
| Data::Package(c) => Ok(c | ||
| Ok(self | ||
| .get_package(&ObjectID::from(*module_id.address()))? |
There was a problem hiding this comment.
I think under the hood this de-serializers to get the package ID and then de-serializes again in the "and_then"? Lets add a TODO here to cache since these things are immutable.
There was a problem hiding this comment.
No it doesn't. module_id is just a pair of id and name.
Though we should cache the package object to avoid fetching from the store every time. At the same time, I feel the VM should do this inside it (to also avoid de-serialize it).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now
AuthorityTemporaryStorekeeps a reference to theAuthorityStore. Whenread_objectis called on the temporary store, it first looks for it in the temporary store, if not found, read it from the authority store.This has a few problems:
AuthorityTemporaryStoreindependently, for instance, if we are doing local execution and the backing store is different.InMemoryStoragein adapter_tests, which has been a pain to keep with with temporary store changes.