Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a common need to check whether a
child_ref
points to a specific child object.Add
is_child
for this purpose. It also enforces the type parameter onChildRef
is the same as the type of the child object, which helps avoid mistakes of mixing up the types (as we have seen in #777).However, there are also cases (still questionable) we need to check the id against a naked id instead of child object. In this case, we also introduce the unsafe version, but only expose it to a limited number of friend classes in the framework.
If in the future we see this a common need, we could open it up.