Remove certificates from Transaction response #8369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
patrickkuo
force-pushed
the
pat/remove_cert
branch
2 times, most recently
from
c438630
to
c785059
Compare
Closed
…ction response and get transaction responses.
patrickkuo
force-pushed
the
pat/remove_cert
branch
from
c785059
to
67f10b0
Compare
lxfind
reviewed
Feb 21, 2023
crates/sui-json-rpc-types/src/lib.rs
Outdated
| pub struct SuiTransactionResponse { | ||
| pub certificate: SuiCertifiedTransaction, | ||
| pub signed_transaction: SuiTransaction, |
There was a problem hiding this comment.
nit: just transaction, or sender_signed_transaction
lxfind
approved these changes
Feb 21, 2023
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also combind execute transaction response and get transaction responses.