Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RPC][cleanup] remove old executeTransaction endpoints #9068

Merged
merged 1 commit into from Mar 9, 2023
Merged

[RPC][cleanup] remove old executeTransaction endpoints #9068

merged 1 commit into from Mar 9, 2023

Conversation

666lcz
Copy link
Contributor

@666lcz 666lcz commented Mar 9, 2023 •
edited

Description

I am doing this cleanup now because it would make the refactoring of adding SuiTransactionResponseOptions easier

  • remove sui_executeTransactionSerializedSig and sui_submitTransaction
  • sui_executeTransaction now takes in a vector of signatures

I decide to keep sui_executeTransaction instead of sui_submitTransaction because we use executeTransaction extensively on the client side and it's more intuitive.

Test Plan

CI

If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.

Type of Change (Check all that apply)

  • user-visible impact
  • breaking change for a client SDKs
  • breaking change for FNs (FN binary must upgrade)
  • breaking change for validators or node operators (must upgrade binaries)
  • breaking change for on-chain data layout
  • necessitate either a data wipe or data migration

Release notes

  • remove sui_executeTransactionSerializedSig and sui_submitTransaction
  • sui_executeTransaction now takes in a vec of signatures

@vercel
Copy link

vercel bot commented Mar 9, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
explorer ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 9, 2023 at 9:12PM (UTC)
explorer-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 9, 2023 at 9:12PM (UTC)
wallet-adapter ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 9, 2023 at 9:12PM (UTC)

@666lcz 666lcz marked this pull request as ready for review March 9, 2023 20:18
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023 •
edited

⚠️ 🦋 Changesets Warning: This PR has changes to public npm packages, but does not contain a changeset. You can create a changeset easily by running pnpm changeset in the root of the Sui repo, and following the prompts. If your change does not need a changeset (e.g. a documentation-only change), you can ignore this message. This warning will be removed when a changeset is added to this pull request.

Learn more about Changesets.

healthydeve
healthydeve approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@healthydeve healthydeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@666lcz 666lcz enabled auto-merge (squash) March 9, 2023 21:28
@666lcz 666lcz merged commit b0a1258 into main Mar 9, 2023
22 checks passed
@666lcz 666lcz deleted the chris-remove-deprecated branch March 9, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@healthydeve healthydeve healthydeve approved these changes

@joyqvq joyqvq Awaiting requested review from joyqvq

@longbowlu longbowlu Awaiting requested review from longbowlu

@patrickkuo patrickkuo Awaiting requested review from patrickkuo

@gegaowp gegaowp Awaiting requested review from gegaowp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@666lcz @healthydeve