Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sui-system] minimum staking threshold of 1 SUI #9961

Merged
merged 5 commits into from
Mar 28, 2023

Conversation

emmazzz
Copy link
Contributor

@emmazzz emmazzz commented Mar 27, 2023

Description

Took over the work @dmitri-perelman started (and almost finished) in #9825 because I can't push to his fork of the repo.

Test Plan

Added some tests.


If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.

Type of Change (Check all that apply)

  • user-visible impact
  • breaking change for a client SDKs
  • breaking change for FNs (FN binary must upgrade)
  • breaking change for validators or node operators (must upgrade binaries)
  • breaking change for on-chain data layout
  • necessitate either a data wipe or data migration

Release notes

@vercel
Copy link

vercel bot commented Mar 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated
explorer ⬜️ Ignored (Inspect) Visit Preview Mar 28, 2023 at 6:25PM (UTC)
explorer-storybook ⬜️ Ignored (Inspect) Visit Preview Mar 28, 2023 at 6:25PM (UTC)
wallet-adapter ⬜️ Ignored (Inspect) Visit Preview Mar 28, 2023 at 6:25PM (UTC)

@dmitri-perelman
Copy link
Contributor

The other missing piece that I didn't finish in #9825 is updating the benchmarking code of staking (I think it's still using small amounts that are smaller than 1 SUI)

@github-actions
Copy link
Contributor

github-actions bot commented Mar 28, 2023

⚠️ 🦋 Changesets Warning: This PR has changes to public npm packages, but does not contain a changeset. You can create a changeset easily by running pnpm changeset in the root of the Sui repo, and following the prompts. If your change does not need a changeset (e.g. a documentation-only change), you can ignore this message. This warning will be removed when a changeset is added to this pull request.

Learn more about Changesets.

Dmitri Perelman and others added 5 commits March 28, 2023 11:25
The threshold is set at the entry level to the Sui system object: the rewards to the validators might still be smaller than the threshold so we can't set it at the level of the staking pool.
@emmazzz emmazzz merged commit 15eae36 into MystenLabs:main Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants