Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial round of types review. #2

Merged
merged 2 commits into from Oct 11, 2022
Merged

Initial round of types review. #2

merged 2 commits into from Oct 11, 2022

Conversation

jgerigmeyer
Copy link

No description provided.

MysteryBlokHed
MysteryBlokHed requested changes Oct 11, 2022
View reviewed changes
Copy link
Owner

@MysteryBlokHed MysteryBlokHed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping out with this! I just have a single comment about the package.json, but everything else looks good 😊

package.json Show resolved Hide resolved
@MysteryBlokHed MysteryBlokHed merged commit 89d1da2 into MysteryBlokHed:types/add-definitions Oct 11, 2022
MysteryBlokHed pushed a commit that referenced this pull request Nov 3, 2022
@jgerigmeyer @LeaVerou
Initial round of types review (#2)
eb2dba8 
* Initial round of types review

* Address review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MysteryBlokHed MysteryBlokHed MysteryBlokHed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jgerigmeyer @MysteryBlokHed