Skip to content

Commit

Permalink
Fix misplaced else condition in osd.cpp. This just looks like a mista…
Browse files Browse the repository at this point in the history
…ke, the else appended to the wrong block. dialog cannot be null, but Create() can and will fail. Related to Coverity defect 700311 'Logically dead code'
  • Loading branch information
stuartm committed May 30, 2012
1 parent 88e9b64 commit 1207821
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions mythtv/libs/libmythtv/osd.cpp
Expand Up @@ -1015,12 +1015,12 @@ void OSD::DialogShow(const QString &window, const QString &text, int updatefor)
}
m_Children.insert(window, m_Dialog);
}
}
else
{
RevertUIScale();
delete dialog;
return;
else
{
RevertUIScale();
delete dialog;
return;
}
}
RevertUIScale();
}
Expand Down

0 comments on commit 1207821

Please sign in to comment.