Skip to content

Commit

Permalink
Remove extraneous ? character in Sat>IP OPTIONS message
Browse files Browse the repository at this point in the history
The extraneous ? character occurs when the QUrl query is initialized to an empty string "".
Fixed by replacing the "" by a QString() in the OPTIONS and the PLAY query composition.
Thanks to Mike Bibbings for reporting and fixing this for the TEARDOWN command,
see https://code.mythtv.org/trac/ticket/13121#comment:20

Refs #13121

(cherry picked from commit 26cc384)
  • Loading branch information
kmdewaal committed Feb 28, 2022
1 parent 75b942f commit 44a4527
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions mythtv/libs/libmythtv/recorders/satiprtsp.cpp
Expand Up @@ -188,7 +188,7 @@ bool SatIPRTSP::Play(QStringList &pids)
LOG(VB_RECORD, LOG_DEBUG, LOC2 + "PLAY");

QUrl url = QUrl(m_requestUrl);
url.setQuery("");
url.setQuery(QString());
url.setPath(QString("/stream=%1").arg(m_streamid));

QString pids_str = QString("pids=%1").arg(!pids.empty() ? pids.join(",") : "none");
Expand Down Expand Up @@ -417,7 +417,7 @@ void SatIPRTSP::timerEvent(QTimerEvent* timerEvent)

QUrl url = QUrl(m_requestUrl);
url.setPath("/");
url.setQuery("");
url.setQuery(QString());

sendMessage(url, "OPTIONS");
}
Expand Down

0 comments on commit 44a4527

Please sign in to comment.