Skip to content

Commit

Permalink
tidy: Tell clang-tidy to ignore mismatch in variable names.
Browse files Browse the repository at this point in the history
The clang-tidy "inconsistent parameter name" checker pointed out one
place where function parameter names differed between the declaration
and the definition of a parameter.  The mismatch occurs between an xxx
cpp file and the corresponding moc_xxx.moc file because moc uses the
names _t1 and _t2.  Tell clang-tidy to ignore this.

https://clang.llvm.org/extra/clang-tidy/checks/readability-inconsistent-declaration-parameter-name.html
  • Loading branch information
linuxdude42 committed Dec 4, 2019
1 parent 3d29aa3 commit 48828e5
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 13 deletions.
13 changes: 0 additions & 13 deletions .clang-tidy
Expand Up @@ -175,19 +175,6 @@ Checks: '-*,
# anyway. ,
-readability-implicit-bool-conversion,
# Has two issues:
#
# function template specialization
# CheckedSet<MythUIStateType> has a primary template
# declaration with different parameter names
#
# function ParentalLevelChangeCheckerPrivate::SigDone has a
# definition with different parameter names
# [readability-inconsistent-declaration-parameter-name]
# void SigDone(bool passwordValid => _t1,
# ParentalLevel::Level toLevel => _t2); ,
-readability-inconsistent-declaration-parameter-name,
# Produces lots of changes. Is this necessary? ,
-readability-isolate-declaration,
Expand Down
1 change: 1 addition & 0 deletions mythtv/libs/libmythmetadata/parentalcontrols.cpp
Expand Up @@ -239,6 +239,7 @@ class ParentalLevelChangeCheckerPrivate : public QObject
}

signals:
// NOLINTNEXTLINE(readability-inconsistent-declaration-parameter-name)
void SigDone(bool passwordValid, ParentalLevel::Level toLevel);

private:
Expand Down

0 comments on commit 48828e5

Please sign in to comment.