tidy: Remove extraneous 'if' checks before calling delete.

According to the c++ reference, deleting a null pointer has no effect, so non-null checks are unnecessary. https://clang.llvm.org/extra/clang-tidy/checks/readability-delete-null-pointer.html
MythTV · Dec 23, 2019 · 4ad8b31 · 4ad8b31
1 parent b32676f
commit 4ad8b31
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 7 deletions.
diff --git a/mythplugins/mytharchive/mytharchive/remoteavformatcontext.h b/mythplugins/mytharchive/mytharchive/remoteavformatcontext.h
@@ -35,8 +35,7 @@ class RemoteAVFormatContext
             avformat_free_context(m_inputFC);
         m_inputFC = avformat_alloc_context();
 
-        if (m_rf)
-            delete m_rf;
+        delete m_rf;
 
         m_inputIsRemote = filename.startsWith("myth://");
         if (m_inputIsRemote)

diff --git a/mythtv/libs/libmythservicecontracts/datacontracthelper.h b/mythtv/libs/libmythservicecontracts/datacontracthelper.h
@@ -118,8 +118,7 @@ inline void DeleteListContents( QVariantList &list )
 
         const QObject *pObject = vValue.value< QObject* >();
 
-        if (pObject != nullptr)
-            delete pObject;
+        delete pObject;
     }
 }
 

diff --git a/mythtv/libs/libmythtv/decoders/nuppeldecoder.h b/mythtv/libs/libmythtv/decoders/nuppeldecoder.h
@@ -24,7 +24,7 @@ class RawDataList
   public:
     RawDataList(struct rtframeheader frameh, unsigned char *data) :
         frameheader(frameh), packet(data) {}
-   ~RawDataList() { if (packet) delete [] packet; }
+   ~RawDataList() { delete [] packet; }
 
     struct rtframeheader frameheader;
     unsigned char *packet;

diff --git a/mythtv/libs/libmythui/platforms/mythdisplaydrm.cpp b/mythtv/libs/libmythui/platforms/mythdisplaydrm.cpp
@@ -12,8 +12,7 @@ MythDisplayDRM::MythDisplayDRM()
 
 MythDisplayDRM::~MythDisplayDRM()
 {
-    if (m_device)
-        delete m_device;
+    delete m_device;
 }
 
 void MythDisplayDRM::ScreenChanged(QScreen *qScreen)