MythDRMDevice: Guard against invalid devices

MythTV · Feb 12, 2020 · 5157ed0 · 5157ed0
1 parent 7512851
commit 5157ed0
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 0 deletions.
diff --git a/mythtv/libs/libmythui/platforms/mythdisplaydrm.cpp b/mythtv/libs/libmythui/platforms/mythdisplaydrm.cpp
@@ -8,6 +8,11 @@ MythDisplayDRM::MythDisplayDRM()
   : MythDisplay()
 {
     m_device = new MythDRMDevice(m_screen);
+    if (!m_device->IsValid())
+    {
+        delete m_device;
+        m_device = nullptr;
+    }
     Initialise();
 }
 
@@ -27,7 +32,14 @@ void MythDisplayDRM::ScreenChanged(QScreen *qScreen)
     }
 
     if (!m_device)
+    {
         m_device = new MythDRMDevice(m_screen);
+        if (!m_device->IsValid())
+        {
+            delete m_device;
+            m_device = nullptr;
+        }
+    }
 }
 
 void MythDisplayDRM::UpdateCurrentMode(void)

diff --git a/mythtv/libs/libmythui/platforms/mythdrmdevice.cpp b/mythtv/libs/libmythui/platforms/mythdrmdevice.cpp
@@ -26,6 +26,7 @@ MythDRMDevice::MythDRMDevice(QScreen *qScreen, const QString& Device)
         return;
     }
 
+    m_valid = true;
     Authenticate();
     if (m_authenticated)
         LOG(VB_GENERAL, m_verbose, LOC + "Authenticated");
@@ -76,6 +77,11 @@ void MythDRMDevice::Close(void)
     m_fd = 0;
 }
 
+bool MythDRMDevice::IsValid(void) const
+{
+    return m_valid;
+}
+
 QString MythDRMDevice::GetSerialNumber(void) const
 {
     return m_serialNumber;

diff --git a/mythtv/libs/libmythui/platforms/mythdrmdevice.h b/mythtv/libs/libmythui/platforms/mythdrmdevice.h
@@ -21,6 +21,7 @@ class MythDRMDevice : public ReferenceCounter
     explicit MythDRMDevice(QScreen *qScreen, const QString& Device = QString());
    ~MythDRMDevice() override;
 
+    bool     IsValid        (void) const;
     QString  GetSerialNumber(void) const;
     QScreen* GetScreen      (void) const;
     QSize    GetResolution  (void) const;
@@ -42,6 +43,7 @@ class MythDRMDevice : public ReferenceCounter
     drmModePropertyBlobPtr GetBlobProperty(drmModeConnectorPtr Connector, const QString& Property);
 
   private:
+    bool               m_valid         { false };
     QScreen*           m_screen        { nullptr };
     QString            m_deviceName    { };
     int                m_fd            { -1 };