tidy: Eliminate unnecessary copying of objects.

The clang-tidy "unnecessary value param" check pointed out many places where objects were passed by copying when they could be passed by const reference. The vast majority of these fixes convert a QString object into a const QString& reference. There are also a number of other objects that get passed by reference instead of copying. Changes made by the clang-tidy program. https://clang.llvm.org/extra/clang-tidy/checks/performance-unnecessary-value-param.html
MythTV · Dec 25, 2019 · 5272f22 · 5272f22
1 parent 1d0a760
commit 5272f22
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/mythtv/libs/libmythui/mythdisplaymode.cpp b/mythtv/libs/libmythui/mythdisplaymode.cpp
@@ -120,7 +120,7 @@ bool MythDisplayMode::CompareRates(double First, double Second, double Precision
     return qAbs(First - Second) < Precision;
 }
 
-int MythDisplayMode::FindBestMatch(const DisplayModeVector Modes,
+int MythDisplayMode::FindBestMatch(const DisplayModeVector& Modes,
                                    const MythDisplayMode& Mode, double &TargetRate)
 {
     double videorate = Mode.RefreshRate();

diff --git a/mythtv/libs/libmythui/mythdisplaymode.h b/mythtv/libs/libmythui/mythdisplaymode.h
@@ -39,7 +39,7 @@ class MUI_PUBLIC MythDisplayMode
     void   ClearRefreshRates(void);
     void   SetRefreshRate(double Rate);
     const std::vector<double>& RefreshRates(void) const;
-    static int      FindBestMatch (const DisplayModeVector Modes,
+    static int      FindBestMatch (const DisplayModeVector& Modes,
                                    const MythDisplayMode& Mode, double& TargetRate);
     static uint64_t CalcKey       (int Width, int Height, double Rate);
     static bool     CompareRates  (double First, double Second, double Precision = 0.01);

diff --git a/mythtv/libs/libmythui/platforms/mythdrmdevice.cpp b/mythtv/libs/libmythui/platforms/mythdrmdevice.cpp
@@ -14,7 +14,7 @@
 
 #define LOC (QString("%1: ").arg(m_deviceName))
 
-MythDRMDevice::MythDRMDevice(QScreen *qScreen, QString Device)
+MythDRMDevice::MythDRMDevice(QScreen *qScreen, const QString& Device)
   : ReferenceCounter("DRMDev"),
     m_screen(qScreen),
     m_deviceName(Device),
@@ -319,7 +319,7 @@ QString MythDRMDevice::FindBestDevice(void)
     return QString();
 }
 
-bool MythDRMDevice::ConfirmDevice(QString Device)
+bool MythDRMDevice::ConfirmDevice(const QString& Device)
 {
     bool result = false;
     int fd = open(Device.toLocal8Bit().constData(), O_RDWR);
@@ -335,7 +335,7 @@ bool MythDRMDevice::ConfirmDevice(QString Device)
     return result;
 }
 
-drmModePropertyBlobPtr MythDRMDevice::GetBlobProperty(drmModeConnectorPtr Connector, QString Property)
+drmModePropertyBlobPtr MythDRMDevice::GetBlobProperty(drmModeConnectorPtr Connector, const QString& Property)
 {
     drmModePropertyBlobPtr result = nullptr;
     if (!Connector || Property.isEmpty())

diff --git a/mythtv/libs/libmythui/platforms/mythdrmdevice.h b/mythtv/libs/libmythui/platforms/mythdrmdevice.h
@@ -18,7 +18,7 @@ extern "C" {
 class MythDRMDevice : public ReferenceCounter
 {
   public:
-    MythDRMDevice(QScreen *qScreen, QString Device = QString());
+    MythDRMDevice(QScreen *qScreen, const QString& Device = QString());
    ~MythDRMDevice() override;
 
     QString  GetSerialNumber(void) const;
@@ -36,9 +36,9 @@ class MythDRMDevice : public ReferenceCounter
     bool     Initialise     (void);
 
     QString  FindBestDevice (void);
-    static bool ConfirmDevice(QString Device);
+    static bool ConfirmDevice(const QString& Device);
 
-    drmModePropertyBlobPtr GetBlobProperty(drmModeConnectorPtr Connector, QString Property);
+    drmModePropertyBlobPtr GetBlobProperty(drmModeConnectorPtr Connector, const QString& Property);
 
   private:
     QScreen*           m_screen        { nullptr };