Skip to content

Commit

Permalink
tidy: Fix two "argument looks like it might be swapped" warnings in x…
Browse files Browse the repository at this point in the history
…mltvparser.

Change a variable name from the generic "text2" to "name", to match the
parameter name in AddPerson.

https://clang.llvm.org/extra/clang-tidy/checks/readability-suspicious-call-argument.html
  • Loading branch information
linuxdude42 committed Nov 6, 2021
1 parent 34f0950 commit 5353443
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions mythtv/programs/mythfilldatabase/xmltvparser.cpp
Expand Up @@ -535,23 +535,23 @@ bool XMLTVParser::parseFile(
if (guest == "yes")
tagname = "guest_star";
}
QString text2 = xml.readElementText(QXmlStreamReader::SkipChildElements);
QString name = xml.readElementText(QXmlStreamReader::SkipChildElements);
#if QT_VERSION < QT_VERSION_CHECK(5,14,0)
QStringList roles = role.split("/", QString::SkipEmptyParts);
#else
QStringList roles = role.split("/", Qt::SkipEmptyParts);
#endif
if (roles.isEmpty())
{
pginfo->AddPerson(tagname, text2,
pginfo->AddPerson(tagname, name,
priority, role);
++priority;
}
else
{
for (auto & r : roles)
{
pginfo->AddPerson(tagname, text2,
pginfo->AddPerson(tagname, name,
priority,
r.simplified());
++priority;
Expand Down

0 comments on commit 5353443

Please sign in to comment.