Several mythfrontend Coverity fixes

"Uninitialized pointer field" issues: - m_hd in AudioTest. ID 746876. - m_MPCM in AudioAdvancedSettings. ID 700946. (unused variable removed) - m_progressDialog in VideoSetupWizard. ID 746882. - m_preview in ThemeChooser. ID 746883.
MythTV · Jun 12, 2013 · 54328bd · 54328bd
1 parent 8999edf
commit 54328bd
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/mythtv/programs/mythfrontend/audiogeneralsettings.cpp b/mythtv/programs/mythfrontend/audiogeneralsettings.cpp
@@ -725,7 +725,7 @@ AudioTest::AudioTest(QString main, QString passthrough,
     : VerticalConfigurationGroup(false, true, false, false),
       m_frontleft(NULL), m_frontright(NULL), m_center(NULL),
       m_surroundleft(NULL), m_surroundright(NULL),
-      m_rearleft(NULL), m_rearright(NULL), m_lfe(NULL),
+      m_rearleft(NULL), m_rearright(NULL), m_lfe(NULL), m_hd(NULL),
       m_main(main), m_passthrough(passthrough), m_settings(settings),
       m_quality(false)
 {

diff --git a/mythtv/programs/mythfrontend/audiogeneralsettings.h b/mythtv/programs/mythfrontend/audiogeneralsettings.h
@@ -117,7 +117,6 @@ class AudioAdvancedSettings : public VerticalConfigurationGroup
     HostCheckBox       *HBRPassthrough();
 
     CheckBoxSetting    *m_triggerMPCM;
-    HostCheckBox       *m_MPCM;
     HostCheckBox       *m_PassThroughOverride;
 };
 

diff --git a/mythtv/programs/mythfrontend/setupwizard_video.cpp b/mythtv/programs/mythfrontend/setupwizard_video.cpp
@@ -31,9 +31,9 @@ VideoSetupWizard::VideoSetupWizard(MythScreenStack *parent,
     : MythScreenType(parent, name),      m_downloadFile(QString()),
       m_testType(ttNone),
       m_generalScreen(general),          m_audioScreen(audio),
-      m_playbackProfileButtonList(NULL), m_testSDButton(NULL),
-      m_testHDButton(NULL),              m_nextButton(NULL),
-      m_prevButton(NULL)
+      m_playbackProfileButtonList(NULL), m_progressDialog(NULL),
+	  m_testSDButton(NULL),              m_testHDButton(NULL),
+	  m_nextButton(NULL),                m_prevButton(NULL)
 {
     m_popupStack = GetMythMainWindow()->GetStack("popup stack");
     m_vdp = new VideoDisplayProfile();

diff --git a/mythtv/programs/mythfrontend/themechooser.cpp b/mythtv/programs/mythfrontend/themechooser.cpp
@@ -72,6 +72,8 @@ class ThemeExtractThread : public QRunnable
 ThemeChooser::ThemeChooser(MythScreenStack *parent,
                            const QString name) :
     MythScreenType(parent, name),
+    m_themes(NULL),
+    m_preview(NULL),
     m_fullPreviewShowing(false),
     m_fullPreviewStateType(NULL),
     m_fullScreenName(NULL),