clazy: Fix static analyzer warnings in latest web-app commits.

QStrings are nontrivial and should be passed as const reference instead of copying. Convert a nontrivial range-for variable into a const reference. Change a variable declaration from "auto" to "auto*" to make it obvious that its a a pointer to something.
MythTV · May 13, 2023 · 57cd225 · 57cd225
1 parent 299de49
commit 57cd225
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 12 deletions.
diff --git a/mythtv/libs/libmythtv/channelscan/channelscanner_web.cpp b/mythtv/libs/libmythtv/channelscan/channelscanner_web.cpp
@@ -49,19 +49,19 @@ ChannelScannerWeb *ChannelScannerWeb::getInstance()
 // Called from Web Service API
 // Run in http thread
 bool  ChannelScannerWeb::StartScan (uint cardid,
-                            QString DesiredServices,
+                            const QString &DesiredServices,
                             bool freeToAirOnly,
                             bool ChannelNumbersOnly,
                             bool CompleteChannelsOnly,
                             bool FullChannelSearch,
                             bool RemoveDuplicates,
                             bool AddFullTS,
                             bool TestDecryptable,
-                            QString ScanType,
-                            QString FreqTable,
+                            const QString &ScanType,
+                            const QString &FreqTable,
                             QString modulation,
-                            QString FirstChan,
-                            QString LastChan,
+                            const QString &FirstChan,
+                            const QString &LastChan,
                             uint ScanId,
                             bool IgnoreSignalTimeout,
                             bool FollowNITSetting,

diff --git a/mythtv/libs/libmythtv/channelscan/channelscanner_web.h b/mythtv/libs/libmythtv/channelscan/channelscanner_web.h
@@ -59,19 +59,19 @@ class MTV_PUBLIC ChannelScannerWeb : public ChannelScanner
   void log(const QString &msg);
 
   bool StartScan (uint CardId,
-                            QString DesiredServices,
+                            const QString &DesiredServices,
                             bool FreeToAirOnly,
                             bool ChannelNumbersOnly,
                             bool CompleteChannelsOnly,
                             bool FullChannelSearch,
                             bool RemoveDuplicates,
                             bool AddFullTS,
                             bool TestDecryptable,
-                            QString ScanType,
-                            QString FreqTable,
+                            const QString &ScanType,
+                            const QString &FreqTable,
                             QString Modulation,
-                            QString FirstChan,
-                            QString LastChan,
+                            const QString &FirstChan,
+                            const QString &LastChan,
                             uint ScanId,
                             bool IgnoreSignalTimeout,
                             bool FollowNITSetting,

diff --git a/mythtv/programs/mythbackend/servicesv2/v2channel.cpp b/mythtv/programs/mythbackend/servicesv2/v2channel.cpp
@@ -1116,9 +1116,9 @@ V2ScanList*  V2Channel::GetScanList  ( uint SourceId)
 {
     auto scanList = LoadScanList(SourceId);
     auto * pResult = new V2ScanList();
-    for (ScanInfo scan : scanList)
+    for (const ScanInfo &scan : scanList)
     {
-        auto pItem = pResult->AddNewScan();
+        auto *pItem = pResult->AddNewScan();
         pItem->setScanId    (scan.m_scanid);
         pItem->setCardId    (scan.m_cardid);
         pItem->setSourceId  (scan.m_sourceid);