Don't include all of the standard namespace. (libmythbase)

Including all of the standard namespace is considered bad practice. It
defeats the purpose of namespaces, and pollutes the global name table.

mythtv/libs/libmythbase/dbcheckcommon.cpp

@@ -6,7 +6,6 @@
 
 #include <cstdio>
 #include <iostream>
-using namespace std;
 
 #include <QString>
 #include <QSqlError>

mythtv/libs/libmythbase/filesysteminfo.cpp

@@ -16,8 +16,6 @@
 #include <sys/mount.h>  // for struct statfs
 #endif
 
-using namespace std;
-
 #include <QList>
 #include <QString>
 #include <QStringList>
@@ -190,7 +188,7 @@ void FileSystemInfo::Consolidate(QList<FileSystemInfo> &disks,
             if (it2->getFSysID() != -1) // disk has already been matched
                 continue;
 
-            int bSize = max(32, max(it1->getBlockSize(), it2->getBlockSize())
+            int bSize = std::max(32, std::max(it1->getBlockSize(), it2->getBlockSize())
                                         / 1024);
             int64_t diffSize = it1->getTotalSpace() - it2->getTotalSpace();
             int64_t diffUsed = it1->getUsedSpace() - it2->getUsedSpace();

mythtv/libs/libmythbase/iso639.cpp

@@ -7,13 +7,11 @@
 
 #include <QStringList>
 
-using namespace std;
-
 QMap<int, QString>    iso639_key_to_english_name;
 static QMap<int, int> s_iso639_key2_to_key3;
 static QMap<int, int> s_iso639_key3_to_canonical_key3;
 static QStringList    s_languages;
-static vector<int>    s_language_keys;
+static std::vector<int> s_language_keys;
 
 /* Note: this file takes a long time to compile. **/
 
@@ -55,7 +53,7 @@ QStringList iso639_get_language_list(void)
     return s_languages;
 }
 
-vector<int> iso639_get_language_key_list(void)
+std::vector<int> iso639_get_language_key_list(void)
 {
     if (s_language_keys.empty())
     {

mythtv/libs/libmythbase/logging.cpp

@@ -12,8 +12,6 @@
 #include <QVariantMap>
 #include <iostream>
 
-using namespace std;
-
 #include "mythlogging.h"
 #include "logging.h"
 #include "loggingserver.h"
@@ -941,7 +939,7 @@ void verboseHelp(void)
 {
     QString m_verbose = userDefaultValueStr.simplified().replace(' ', ',');
 
-    cerr << "Verbose debug levels.\n"
+    std::cerr << "Verbose debug levels.\n"
             "Accepts any combination (separated by comma) of:\n\n";
 
     for (VerboseMap::Iterator vit = verboseMap.begin();
@@ -951,11 +949,11 @@ void verboseHelp(void)
         QString name = QString("  %1").arg(item->name, -15, ' ');
         if (item->helpText.isEmpty())
             continue;
-        cerr << name.toLocal8Bit().constData() << " - " <<
-                item->helpText.toLocal8Bit().constData() << endl;
+        std::cerr << name.toLocal8Bit().constData() << " - "
+                  << item->helpText.toLocal8Bit().constData() << std::endl;
     }
 
-    cerr << endl <<
+    std::cerr << std::endl <<
       "The default for this program appears to be: '-v " <<
       m_verbose.toLocal8Bit().constData() << "'\n\n"
       "Most options are additive except for 'none' and 'all'.\n"
@@ -967,13 +965,14 @@ void verboseHelp(void)
       "prefixing them with 'no', so you may use '-v all,nodatabase'\n"
       "to view all but database debug messages.\n\n";
 
-    cerr << "The 'global' loglevel is specified with --loglevel, but can be\n"
+    std::cerr
+         << "The 'global' loglevel is specified with --loglevel, but can be\n"
          << "overridden on a component by component basis by appending "
          << "':level'\n"
          << "to the component.\n"
          << "    For example: -v gui:debug,channel:notice,record\n\n";
 
-    cerr << "Some debug levels may not apply to this program.\n" << endl;
+    std::cerr << "Some debug levels may not apply to this program.\n" << std::endl;
 }
 
 /// \brief  Parse the --verbose commandline argument and set the verbose level
@@ -993,7 +992,7 @@ int verboseArgParse(const QString& arg)
 
     if (arg.startsWith('-'))
     {
-        cerr << "Invalid or missing argument to -v/--verbose option\n";
+        std::cerr << "Invalid or missing argument to -v/--verbose option\n";
         return GENERIC_EXIT_INVALID_CMDLINE;
     }
 
@@ -1023,11 +1022,11 @@ int verboseArgParse(const QString& arg)
         }
         if (option == "important")
         {
-            cerr << "The \"important\" log mask is no longer valid.\n";
+            std::cerr << "The \"important\" log mask is no longer valid.\n";
         }
         else if (option == "extra")
         {
-            cerr << "The \"extra\" log mask is no longer valid.  Please try "
+            std::cerr << "The \"extra\" log mask is no longer valid.  Please try "
                     "--loglevel debug instead.\n";
         }
         else if (option == "default")
@@ -1088,8 +1087,8 @@ int verboseArgParse(const QString& arg)
             }
             else
             {
-                cerr << "Unknown argument for -v/--verbose: " <<
-                        option.toLocal8Bit().constData() << endl;;
+                std::cerr << "Unknown argument for -v/--verbose: " <<
+                        option.toLocal8Bit().constData() << std::endl;;
                 return GENERIC_EXIT_INVALID_CMDLINE;
             }
         }

mythtv/libs/libmythbase/loggingserver.cpp

@@ -13,8 +13,6 @@
 #include <QSocketNotifier>
 #include <iostream>
 
-using namespace std;
-
 #include "mythlogging.h"
 #include "logging.h"
 #include "loggingserver.h"

mythtv/libs/libmythbase/mthread.cpp

@@ -20,7 +20,6 @@
  */
 
 #include <iostream>
-using namespace std;
 
 // Qt headers
 #include <QStringList>
@@ -159,13 +158,13 @@ void MThread::Cleanup(void)
         return;
 
     // logging has been stopped so we need to use iostream...
-    cerr<<"Error: Not all threads were shut down properly: "<<endl;
+    std::cerr<<"Error: Not all threads were shut down properly: "<<std::endl;
     for (auto *thread : qAsConst(badGuys))
     {
-        cerr<<"Thread "<<qPrintable(thread->objectName())
-            <<" is still running"<<endl;
+        std::cerr<<"Thread "<<qPrintable(thread->objectName())
+                 <<" is still running"<<std::endl;
     }
-    cerr<<endl;
+    std::cerr<<std::endl;
 
     static const int kTimeout = 5000;
     MythTimer t;

mythtv/libs/libmythbase/mthreadpool.cpp

@@ -74,7 +74,6 @@
 
 // C++ headers
 #include <algorithm>
-using namespace std;
 
 // Qt headers
 #include <QCoreApplication>
@@ -218,7 +217,7 @@ class MThreadPoolPrivate
 
     int GetRealMaxThread(void) const
     {
-        return max(m_maxThreadCount,1) + m_reserveThread;
+        return std::max(m_maxThreadCount,1) + m_reserveThread;
     }
 
     mutable QMutex m_lock;