Fix a couple of memory leaks in mythgame. Coverity defects 703765 & 7…

…03766
MythTV · Jun 4, 2012 · 7809398 · 7809398
1 parent faf6dbc
commit 7809398
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/mythplugins/mythgame/mythgame/gamescan.cpp b/mythplugins/mythgame/mythgame/gamescan.cpp
@@ -114,11 +114,11 @@ void GameScannerThread::updateDB()
     {
         if (!(*p).indb)
         {
-            RomInfo *add = new RomInfo(0, (*p).romfile, (*p).system,
+            RomInfo add(0, (*p).romfile, (*p).system,
-                               (*p).romname, "", "", "", (*p).rompath,
+                        (*p).romname, "", "", "", (*p).rompath,
-                               "", "", 0, (*p).gametype, 0, "", "", "",
+                        "", "", 0, (*p).gametype, 0, "", "", "",
-                               "", "", "", "", "");
+                        "", "", "", "", "");
-            add->SaveToDatabase();
+            add.SaveToDatabase();
             m_DBDataChanged = true;
         }
         if (m_HasGUI)

diff --git a/mythplugins/mythgame/mythgame/rominfo.cpp b/mythplugins/mythgame/mythgame/rominfo.cpp
@@ -369,7 +369,7 @@ QList<RomInfo*> RomInfo::GetAllRomInfo()
 
 RomInfo *RomInfo::GetRomInfoById(int id)
 {
-    RomInfo *ret = new RomInfo();
+    RomInfo *ret = NULL;
 
     MSqlQuery query(MSqlQuery::InitCon());
 
@@ -382,10 +382,7 @@ RomInfo *RomInfo::GetRomInfoById(int id)
     query.bindValue(":INTID", id);
 
     if (!query.exec())
-    {
         MythDB::DBError("GetRomInfoById", query);
-        return ret;
-    }
 
     if (query.next())
     {
@@ -412,6 +409,9 @@ RomInfo *RomInfo::GetRomInfoById(int id)
                            query.value(17).toString());
     }
 
+    if (!ret)
+        ret = new RomInfo();
+
     return ret;
 }