cppcheck: Fix two "condition is always false" warnings.

In both of these cases an unsigned value is tested to see if it is less than zero, which is false by definition. Remove these tests.
MythTV · Oct 2, 2020 · 8b5c9ea · 8b5c9ea
1 parent c985336
commit 8b5c9ea
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 4 deletions.
diff --git a/mythtv/libs/libmythtv/visualisations/goom/lines.cpp b/mythtv/libs/libmythtv/visualisations/goom/lines.cpp
@@ -23,8 +23,6 @@ lighten (unsigned char value, float power)
 		val = (int) t; // (32.0F * log (t));
 		if (val > 255)
 			val = 255;
-		if (val < 0)
-			val = 0;
 		return val;
 	}
         return 0;

diff --git a/mythtv/libs/libmythtv/visualisations/goom/tentacle3d.cpp b/mythtv/libs/libmythtv/visualisations/goom/tentacle3d.cpp
@@ -47,8 +47,6 @@ lighten (unsigned char value, float power)
 		val = (int) t; // (32.0F * log (t));
 		if (val > 255)
 			val = 255;
-		if (val < 0)
-			val = 0;
 		return val;
 	}
         return 0;