Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove initializers TSPacket and TSHeader
The initialization was added in commit 8e70b50 on Jan 10, 2020 to remove warnings from a static code analyzer. However, the initialization is not needed at all, see comments on lines 52-53 and 61-62, added in commit 6a4845b on May 1, 2008 and on line 207, added in commit 4ca584a on Jun 21, 2008 by the original author of this code. Superfluous initializations are not harmful but in this case it can cost a significant amount of processing resources. For one full transport stream this can be 4 to 5 Mbyte/second that is needlessly initialized.
- Loading branch information
9882cac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think any initialization was actually occurring, since no object of this type is ever created. This structure only over used when it is overlaid onto a pre-existing buffer in memory.