tidy: Use the emplace_back function where possible.

Instead of calling the STL push_back with an explicitly constructed temporary object, the two calls can be collapsed into a single emplace_back call. This code is less verbose and potentially more efficient. These changes were suggested by the clang-tidy program. https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-emplace.html
MythTV · Mar 26, 2019 · b87f6fd · b87f6fd
1 parent d57089c
commit b87f6fd
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 15 deletions.
diff --git a/mythtv/libs/libmythtv/channelscan/scaninfo.cpp b/mythtv/libs/libmythtv/channelscan/scaninfo.cpp
@@ -264,12 +264,11 @@ vector<ScanInfo> LoadScanList(void)
 
     while (query.next())
     {
-        list.push_back(
-            ScanInfo(query.value(0).toUInt(),
-                     query.value(1).toUInt(),
-                     query.value(2).toUInt(),
-                     (bool) query.value(3).toUInt(),
-                     MythDate::as_utc(query.value(4).toDateTime())));
+        list.emplace_back(query.value(0).toUInt(),
+                          query.value(1).toUInt(),
+                          query.value(2).toUInt(),
+                          (bool) query.value(3).toUInt(),
+                          MythDate::as_utc(query.value(4).toDateTime()));
     }
 
     return list;

diff --git a/mythtv/libs/libmythtv/recorders/asichannel.cpp b/mythtv/libs/libmythtv/recorders/asichannel.cpp
@@ -12,7 +12,7 @@
 ASIChannel::ASIChannel(TVRec *parent, const QString &device) :
     DTVChannel(parent), m_device(device)
 {
-    m_tuner_types.push_back(DTVTunerType(DTVTunerType::kTunerTypeASI));
+    m_tuner_types.emplace_back(DTVTunerType::kTunerTypeASI);
 }
 
 ASIChannel::~ASIChannel(void)

diff --git a/mythtv/libs/libmythtv/recorders/hdhrstreamhandler.cpp b/mythtv/libs/libmythtv/recorders/hdhrstreamhandler.cpp
@@ -318,22 +318,22 @@ bool HDHRStreamHandler::Open(void)
             if (status_channel ==  "none")
             {
                 LOG(VB_RECORD, LOG_INFO, LOC + "Cable card is not present");
-                m_tuner_types.push_back(DTVTunerType(DTVTunerType::kTunerTypeATSC));
+                m_tuner_types.emplace_back(DTVTunerType::kTunerTypeATSC);
             }
             else
             {
                 LOG(VB_RECORD, LOG_INFO, LOC + "Cable card is present");
-                m_tuner_types.push_back(DTVTunerType(DTVTunerType::kTunerTypeOCUR));
+                m_tuner_types.emplace_back(DTVTunerType::kTunerTypeOCUR);
             }
         }
         else if (QString(model).toLower().contains("dvb"))
         {
-            m_tuner_types.push_back(DTVTunerType(DTVTunerType::kTunerTypeDVBT));
-            m_tuner_types.push_back(DTVTunerType(DTVTunerType::kTunerTypeDVBC));
+            m_tuner_types.emplace_back(DTVTunerType::kTunerTypeDVBT);
+            m_tuner_types.emplace_back(DTVTunerType::kTunerTypeDVBC);
         }
         else
         {
-            m_tuner_types.push_back(DTVTunerType(DTVTunerType::kTunerTypeATSC));
+            m_tuner_types.emplace_back(DTVTunerType::kTunerTypeATSC);
         }
 
         return true;

diff --git a/mythtv/libs/libmythtv/tv_rec.cpp b/mythtv/libs/libmythtv/tv_rec.cpp
@@ -2355,7 +2355,7 @@ bool TVRec::CheckChannelPrefix(const QString &prefix,
                     fchanid.push_back(query.value(0).toUInt());
                     fchannum.push_back(query.value(1).toString());
                     finputid.push_back(query.value(2).toUInt());
-                    fspacer.push_back(spacers[j]);
+                    fspacer.emplace_back(spacers[j]);
 #if DEBUG_CHANNEL_PREFIX
                     LOG(VB_GENERAL, LOG_DEBUG,
                         QString("(%1,%2) Adding %3 rec %4")

diff --git a/mythtv/libs/libmythtv/videoout_omx.cpp b/mythtv/libs/libmythtv/videoout_omx.cpp
@@ -1148,8 +1148,8 @@ bool VideoOutputOMX::CreateBuffers(
     std::vector<YUVInfo> yuvinfo;
     for (uint i = 0; i < vbuffers.Size(); ++i)
     {
-        yuvinfo.push_back(YUVInfo(video_dim_disp.width(),
-            video_dim_disp.height(), nBufferSize, pitches, offsets));
+        yuvinfo.emplace_back(video_dim_disp.width(), video_dim_disp.height(),
+                             nBufferSize, pitches, offsets);
         void *buf = av_malloc(nBufferSize + 64);
         if (!buf)
         {