clazy: Combine multiple calls to QString::arg in mythfilldatabase.

Each call to QString::arg causes the Qt libraries to scan the string
to find the lowest numbered place marker, and it causes a memory
allocate to store the resulting integrated string. Consecutive calls
to ::arg with string arguments can be combined into a single call,
thus reducing the number of required string scans and (more
importantly) memory allocations.

mythtv/programs/mythfilldatabase/channeldata.cpp

@@ -253,7 +253,7 @@ void ChannelData::handleChannels(int id, ChannelInfoList *chanlist) const
             {
                 LOG(VB_GENERAL, LOG_INFO,
                     QString("Converting old xmltvid (%1) to new (%2)")
-                        .arg((*i).m_oldXmltvId).arg((*i).m_xmltvId));
+                        .arg((*i).m_oldXmltvId, (*i).m_xmltvId));
 
                 query.prepare("UPDATE channel "
                               "SET xmltvid = :NEWXMLTVID"
@@ -273,7 +273,7 @@ void ChannelData::handleChannels(int id, ChannelInfoList *chanlist) const
         {
             LOG(VB_XMLTV, LOG_DEBUG,
                     QString("Match found for xmltvid %1 to channel %2 (%3)")
-                        .arg((*i).m_xmltvId).arg(dbChan.m_name).arg(dbChan.m_chanId));
+                .arg((*i).m_xmltvId, dbChan.m_name, QString::number(dbChan.m_chanId)));
             if (m_interactive)
             {
 

mythtv/programs/mythfilldatabase/filldata.cpp

@@ -136,14 +136,13 @@ bool FillData::GrabData(const Source& source, int offset)
     if (query1.next())
         configfile = query1.value(0).toString();
     else
-        configfile = QString("%1/%2.xmltv").arg(GetConfDir())
-                                           .arg(source.name);
+        configfile = QString("%1/%2.xmltv").arg(GetConfDir(), source.name);
 
     LOG(VB_GENERAL, LOG_INFO,
         QString("XMLTV config file is: %1").arg(configfile));
 
     QString command = QString("nice %1 --config-file '%2' --output %3")
-        .arg(xmltv_grabber).arg(configfile).arg(filename);
+        .arg(xmltv_grabber, configfile, filename);
 
 
     if (source.xmltvgrabber_prefmethod != "allatonce"  || m_noAllAtOnce)
@@ -313,9 +312,9 @@ bool FillData::Run(SourceList &sourcelist)
             continue;
         }
 
-        LOG(VB_GENERAL, LOG_INFO, sidStr.arg((*it).id)
-                                  .arg((*it).name)
-                                  .arg(xmltv_grabber));
+        LOG(VB_GENERAL, LOG_INFO, sidStr.arg(QString::number((*it).id),
+                                             (*it).name,
+                                             xmltv_grabber));
 
         query.prepare(
             "SELECT COUNT(chanid) FROM channel "

mythtv/programs/mythfilldatabase/main.cpp

@@ -467,7 +467,7 @@ int main(int argc, char *argv[])
 
             LOG(VB_GENERAL, LOG_INFO,
                 QString("    %1 -> %2 (part %3 of %4)")
-                    .arg(orig_programid).arg(new_programid)
+                    .arg(orig_programid, new_programid)
                     .arg(partnum).arg(parttotal));
 
             repl.bindValue(":NEWID", new_programid);
@@ -478,8 +478,7 @@ int main(int argc, char *argv[])
             {
                 LOG(VB_GENERAL, LOG_INFO,
                     QString("Fudging programid from '%1' to '%2'")
-                        .arg(orig_programid)
-                        .arg(new_programid));
+                        .arg(orig_programid, new_programid));
             }
             else
                 found += repl.numRowsAffected();