tidy: Fix virtual calls from object constructor/destructor.

Clang-tidy complains about a class calling a virtual function from its constructor or destructor. During constructors and destructors virtual functions aren't virtual, calling the function in that class and not any derived class. Add the class name to these calls to eliminate the warning messages. https://clang.llvm.org/extra/clang-tidy/checks/clang-analyzer-optin.cplusplus.VirtualCall.html
MythTV · Dec 25, 2019 · bd0291e · bd0291e
1 parent a5aba64
commit bd0291e
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/mythtv/libs/libmythbase/platforms/mythpowerdbus.cpp b/mythtv/libs/libmythbase/platforms/mythpowerdbus.cpp
@@ -61,7 +61,7 @@ MythPowerDBus::MythPowerDBus()
 {
     m_delayTimer.setSingleShot(true);
     connect(&m_delayTimer, &QTimer::timeout, this, &MythPowerDBus::ReleaseLock);
-    Init();
+    MythPowerDBus::Init();
 }
 
 MythPowerDBus::~MythPowerDBus()

diff --git a/mythtv/libs/libmythtv/opengl/mythnvdecinterop.cpp b/mythtv/libs/libmythtv/opengl/mythnvdecinterop.cpp
@@ -26,7 +26,7 @@ MythNVDECInterop::MythNVDECInterop(MythRenderOpenGL *Context)
 MythNVDECInterop::~MythNVDECInterop()
 {
     m_referenceFrames.clear();
-    DeleteTextures();
+    MythNVDECInterop::DeleteTextures();
     CleanupContext(m_context, m_cudaFuncs, m_cudaContext);
 }
 

diff --git a/mythtv/libs/libmythtv/opengl/mythvaapidrminterop.cpp b/mythtv/libs/libmythtv/opengl/mythvaapidrminterop.cpp
@@ -89,7 +89,7 @@ void MythVAAPIInteropDRM::DestroyDeinterlacer(void)
     if (m_filterGraph)
     {
         LOG(VB_PLAYBACK, LOG_INFO, LOC + "Deleting deinterlacer frame cache");
-        DeleteTextures();
+        MythVAAPIInteropDRM::DeleteTextures();
         CleanupDRMPRIME();
     }
     MythVAAPIInterop::DestroyDeinterlacer();