Skip to content

Commit

Permalink
Fix MythPlayer::GetRawVideoFrame() for mythcommflag.
Browse files Browse the repository at this point in the history
Fix MythPlayer::GetRawVideoFrame() to return the correct frame number.
This change fixes mythcommflag so that it will return consistent results
across multiple runs.  It should also improve commercial detection
accuracy, as the frame numbers identified by the different methods will
actually be precise--allowing for better comparing the results of the
different methods.

Although this commit has my name for the signed-off line, I didn't do
much.  Thanks to Kevin Ross for the debugging and the patch, to Taylor
Ralph and Mark Kendall for actually reviewing the patch, and to all the
users and devs who ran with the patch to test it (and saw
greatly-improved commercial flagging results).

Fixes #9997.

Signed-off-by: Michael T. Dean <mdean@mythtv.org>
(cherry picked from commit f135d5d)
  • Loading branch information
k-ross authored and sphery committed Oct 9, 2011
1 parent a24ecbf commit cb01f30
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion mythtv/libs/libmythtv/mythplayer.cpp
Expand Up @@ -4089,7 +4089,8 @@ VideoFrame* MythPlayer::GetRawVideoFrame(long long frameNumber)
VERBOSE(VB_PLAYBACK, LOC + QString("Waited 100ms for video frame"));
}

return videoOutput->GetLastDecodedFrame();
videoOutput->StartDisplayingFrame();
return videoOutput->GetLastShownFrame();
}

QString MythPlayer::GetEncodingType(void) const
Expand Down

0 comments on commit cb01f30

Please sign in to comment.