tidy: Fix virtual calls from object destructors.

Clang-tidy complains that several functions are calling virtual functions from their destructors. During constructors and destructors virtual functions aren't virtual, calling the function in that class and not any derived class. Add the class name to these calls to eliminate the warning messages. https://clang.llvm.org/extra/clang-tidy/checks/clang-analyzer-optin.cplusplus.VirtualCall.html
MythTV · Dec 6, 2019 · cc86ec5 · cc86ec5
1 parent 01d2547
commit cc86ec5
Show file tree

Hide file tree

Showing 8 changed files with 10 additions and 10 deletions.
diff --git a/mythtv/libs/libmythtv/mythvideoout.cpp b/mythtv/libs/libmythtv/mythvideoout.cpp
@@ -269,7 +269,7 @@ MythVideoOutput::MythVideoOutput()
 MythVideoOutput::~MythVideoOutput()
 {
     delete m_dbDisplayProfile;
-    ResizeForGui();
+    MythVideoOutput::ResizeForGui();
     if (m_display)
         MythDisplay::AcquireRelease(false);
 }

diff --git a/mythtv/libs/libmythtv/opengl/mythdrmprimeinterop.cpp b/mythtv/libs/libmythtv/opengl/mythdrmprimeinterop.cpp
@@ -18,7 +18,7 @@ MythDRMPRIMEInterop::MythDRMPRIMEInterop(MythRenderOpenGL *Context)
 
 MythDRMPRIMEInterop::~MythDRMPRIMEInterop()
 {
-    DeleteTextures();
+    MythDRMPRIMEInterop::DeleteTextures();
 }
 
 void MythDRMPRIMEInterop::DeleteTextures(void)

diff --git a/mythtv/libs/libmythtv/opengl/mythopenglinterop.cpp b/mythtv/libs/libmythtv/opengl/mythopenglinterop.cpp
@@ -210,7 +210,7 @@ MythOpenGLInterop::MythOpenGLInterop(MythRenderOpenGL *Context, Type InteropType
 
 MythOpenGLInterop::~MythOpenGLInterop()
 {
-    DeleteTextures();
+    MythOpenGLInterop::DeleteTextures();
     if (m_context)
         m_context->DecrRef();
 }

diff --git a/mythtv/libs/libmythtv/opengl/mythvaapidrminterop.cpp b/mythtv/libs/libmythtv/opengl/mythvaapidrminterop.cpp
@@ -53,8 +53,8 @@ MythVAAPIInteropDRM::~MythVAAPIInteropDRM()
     CleanupDRMPRIME();
 
     CleanupReferenceFrames();
-    DestroyDeinterlacer();
-    DeleteTextures();
+    MythVAAPIInteropDRM::DestroyDeinterlacer();
+    MythVAAPIInteropDRM::DeleteTextures();
 
     if (m_drmFile.isOpen())
         m_drmFile.close();

diff --git a/mythtv/libs/libmythtv/opengl/mythvaapiinterop.cpp b/mythtv/libs/libmythtv/opengl/mythvaapiinterop.cpp
@@ -79,7 +79,7 @@ MythVAAPIInterop::MythVAAPIInterop(MythRenderOpenGL *Context, Type InteropType)
 
 MythVAAPIInterop::~MythVAAPIInterop()
 {
-    DestroyDeinterlacer();
+    MythVAAPIInterop::DestroyDeinterlacer();
     if (m_vaDisplay)
         if (vaTerminate(m_vaDisplay) != VA_STATUS_SUCCESS)
             LOG(VB_GENERAL, LOG_WARNING, LOC + "Error closing VAAPI display");

diff --git a/mythtv/libs/libmythtv/opengl/mythvideooutopengl.cpp b/mythtv/libs/libmythtv/opengl/mythvideooutopengl.cpp
@@ -158,7 +158,7 @@ MythVideoOutputOpenGL::MythVideoOutputOpenGL(QString Profile)
 
 MythVideoOutputOpenGL::~MythVideoOutputOpenGL()
 {
-    DestroyBuffers();
+    MythVideoOutputOpenGL::DestroyBuffers();
     while (!m_openGLVideoPiPs.empty())
     {
         delete *m_openGLVideoPiPs.begin();
@@ -180,7 +180,7 @@ MythVideoOutputOpenGL::~MythVideoOutputOpenGL()
 
 void MythVideoOutputOpenGL::DestroyBuffers(void)
 {
-    DiscardFrames(true, true);
+    MythVideoOutputOpenGL::DiscardFrames(true, true);
     m_videoBuffers.DeleteBuffers();
     m_videoBuffers.Reset();
     m_buffersCreated = false;

diff --git a/mythtv/libs/libmythui/opengl/mythpainteropengl.cpp b/mythtv/libs/libmythui/opengl/mythpainteropengl.cpp
@@ -25,7 +25,7 @@ MythOpenGLPainter::~MythOpenGLPainter()
     if (VERBOSE_LEVEL_CHECK(VB_GPU, LOG_INFO))
         m_render->logDebugMarker("PAINTER_RELEASE_START");
     Teardown();
-    FreeResources();
+    MythOpenGLPainter::FreeResources();
     if (VERBOSE_LEVEL_CHECK(VB_GPU, LOG_INFO))
         m_render->logDebugMarker("PAINTER_RELEASE_END");
 }

diff --git a/mythtv/libs/libmythui/opengl/mythrenderopengl.cpp b/mythtv/libs/libmythui/opengl/mythrenderopengl.cpp
@@ -149,7 +149,7 @@ MythRenderOpenGL::~MythRenderOpenGL()
     if (!isValid())
         return;
     disconnect(this, &QOpenGLContext::aboutToBeDestroyed, this, &MythRenderOpenGL::contextToBeDestroyed);
-    ReleaseResources();
+    MythRenderOpenGL::ReleaseResources();
 }
 
 void MythRenderOpenGL::messageLogged(const QOpenGLDebugMessage &Message)