Skip to content

Commit

Permalink
Fix potential derefernce after NULL check in AudioConfigSettings.
Browse files Browse the repository at this point in the history
I actually can't see how m_MaxAudioChannels, m_AudioUpmix or
m_AudioUpmixType could ever be NULL, but I think this changee is what
the original author intended.  Fixes Coverity 700422.
  • Loading branch information
gigem committed Jun 19, 2013
1 parent 2338de1 commit cfd2ee8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion mythtv/programs/mythfrontend/audiogeneralsettings.cpp
Expand Up @@ -242,7 +242,7 @@ void AudioConfigSettings::AudioRescan()

void AudioConfigSettings::UpdateVisibility(const QString &device)
{
if (!m_MaxAudioChannels && !m_AudioUpmix && !m_AudioUpmixType)
if (!m_MaxAudioChannels || !m_AudioUpmix || !m_AudioUpmixType)
return;

int cur_speakers = m_MaxAudioChannels->getValue().toInt();
Expand Down

0 comments on commit cfd2ee8

Please sign in to comment.