clazy: Fix a couple of range-loop warnings.

From the clazy docs: Finds places where you're using C++11 range-loops with non-const Qt containers (potential detach).
MythTV · Nov 1, 2020 · e71ca12 · e71ca12
1 parent b4aea72
commit e71ca12
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 6 deletions.
diff --git a/mythtv/libs/libmythmetadata/imagemanager.cpp b/mythtv/libs/libmythmetadata/imagemanager.cpp
@@ -313,7 +313,8 @@ ImageAdapterBase::ImageAdapterBase() :
 {
     // Generate glob list from supported extensions
     QStringList glob;
-    for (const auto& ext : (m_imageFileExt + m_videoFileExt))
+    QStringList allExt = m_imageFileExt + m_videoFileExt;
+    for (const auto& ext : qAsConst(allExt))
         glob << "*." + ext;
 
     // Apply filters to only detect image files

diff --git a/mythtv/libs/libmythtv/overlays/mythnavigationoverlay.cpp b/mythtv/libs/libmythtv/overlays/mythnavigationoverlay.cpp
@@ -61,7 +61,7 @@ bool MythNavigationOverlay::Create()
         if (i != m_visibleGroup)
             group->SetVisible(false);
         QList<MythUIType *> * children = group->GetAllChildren();
-        for (auto * child : *children)
+        for (auto * child : qAsConst(*children))
         {
             if (child != more)
             {

diff --git a/mythtv/libs/libmythui/platforms/mythscreensaverdbus.cpp b/mythtv/libs/libmythui/platforms/mythscreensaverdbus.cpp
@@ -138,19 +138,19 @@ MythScreenSaverDBus::MythScreenSaverDBus(QObject *Parent)
 MythScreenSaverDBus::~MythScreenSaverDBus()
 {
     MythScreenSaverDBus::Restore();
-    for (auto * interface : m_dbusPrivateInterfaces)
+    for (auto * interface : qAsConst(m_dbusPrivateInterfaces))
         delete interface;
 }
 
 void MythScreenSaverDBus::Disable()
 {
-    for (auto * interface : m_dbusPrivateInterfaces)
+    for (auto * interface : qAsConst(m_dbusPrivateInterfaces))
         interface->Inhibit();
 }
 
 void MythScreenSaverDBus::Restore()
 {
-    for (auto * interface : m_dbusPrivateInterfaces)
+    for (auto * interface : qAsConst(m_dbusPrivateInterfaces))
         interface->UnInhibit();
 }
 

diff --git a/mythtv/programs/mythfrontend/gallerythumbview.cpp b/mythtv/programs/mythfrontend/gallerythumbview.cpp
@@ -938,7 +938,7 @@ void GalleryThumbView::UpdateScanProgress(const QString &scanner,
     // Aggregate all running scans
     int currentAgg = 0;
     int totalAgg = 0;
-    for (IntPair scan : m_scanProgress)
+    for (IntPair scan : qAsConst(m_scanProgress))
     {
         currentAgg += scan.first;
         totalAgg   += scan.second;