Skip to content

Commit

Permalink
Don't compile unused code to write a playlist to a CD.
Browse files Browse the repository at this point in the history
This code isn't currently callable from a running frontend.  It needs
to be updated to handle storage groups and the new user interface
dialogs.  Not compiling it eliminates the last warning message in the
mythplugins directory tree.
  • Loading branch information
linuxdude42 committed Aug 22, 2018
1 parent b3b2137 commit ef1893f
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 3 deletions.
9 changes: 6 additions & 3 deletions mythplugins/mythmusic/mythmusic/playlist.cpp
Expand Up @@ -150,10 +150,12 @@ Playlist::Playlist(void) :
m_name(tr("oops")),
m_parent(NULL),
m_changed(false),
m_doSave(true),
m_doSave(true)
#ifdef CD_WRTITING_FIXED
m_progress(NULL),
m_proc(NULL),
m_procExitVal(0)
#endif
{
}

Expand Down Expand Up @@ -1130,8 +1132,8 @@ MusicMetadata* Playlist::getRawSongAt(int pos) const
}

// Here begins CD Writing things. ComputeSize, CreateCDMP3 & CreateCDAudio
// FIXME non of this is currently used

// FIXME none of this is currently used
#ifdef CD_WRTITING_FIXED
void Playlist::computeSize(double &size_in_MB, double &size_in_sec)
{
//double child_MB;
Expand Down Expand Up @@ -1457,3 +1459,4 @@ int Playlist::CreateCDAudio(void)
{
return -1;
}
#endif
4 changes: 4 additions & 0 deletions mythplugins/mythmusic/mythmusic/playlist.h
Expand Up @@ -112,9 +112,11 @@ class Playlist : public QObject

void resync(void);

#ifdef CD_WRTITING_FIXED
void computeSize(double &size_in_MB, double &size_in_sec);
int CreateCDMP3(void);
int CreateCDAudio(void);
#endif

private slots:
void mkisofsData(int fd);
Expand All @@ -134,9 +136,11 @@ class Playlist : public QObject
PlaylistContainer *m_parent;
bool m_changed;
bool m_doSave;
#ifdef CD_WRTITING_FIXED
MythProgressDialog *m_progress;
MythSystemLegacy *m_proc;
uint m_procExitVal;
#endif
};

#endif

0 comments on commit ef1893f

Please sign in to comment.