Skip to content

Commit

Permalink
tidy: Remove 'const' in declarations where it doesn't affect the sign…
Browse files Browse the repository at this point in the history 
…ature of a function.

https://clang.llvm.org/extra/clang-tidy/checks/readability-avoid-const-params-in-decls.html
  • Loading branch information
@linuxdude42
linuxdude42 committed Mar 19, 2019
1 parent da03c8c commit f6b0e30
Show file tree
Hide file tree
Showing 9 changed files with 44 additions and 44 deletions.
12 changes: 6 additions & 6 deletions mythplugins/mythmusic/mythmusic/cddb.cpp
View file
Expand Up @@ -34,16 +34,16 @@ static const QString& helloID();
*/
struct Dbase
{
static bool Search(Cddb::Matches& res, const Cddb::discid_t discID);
static bool Search(Cddb::Album& a, const QString& genre, const Cddb::discid_t discID);
static bool Search(Cddb::Matches& res, Cddb::discid_t discID);
static bool Search(Cddb::Album& a, const QString& genre, Cddb::discid_t discID);
static bool Write(const Cddb::Album& album);

static void New(const Cddb::discid_t discID, const Cddb::Toc& toc);
static void MakeAlias(const Cddb::Album& album, const Cddb::discid_t discID);
static void New(Cddb::discid_t discID, const Cddb::Toc& toc);
static void MakeAlias(const Cddb::Album& album, Cddb::discid_t discID);

private:
static bool CacheGet(Cddb::Matches& res, const Cddb::discid_t discID);
static bool CacheGet(Cddb::Album& album, const QString& genre, const Cddb::discid_t discID);
static bool CacheGet(Cddb::Matches& res, Cddb::discid_t discID);
static bool CacheGet(Cddb::Album& album, const QString& genre, Cddb::discid_t discID);
static void CachePut(const Cddb::Album& album);

// DiscID to album info cache
Expand Down
10 changes: 5 additions & 5 deletions mythtv/libs/libmyth/mythcontext.cpp
View file
Expand Up @@ -72,10 +72,10 @@ class MythContextPrivate : public QObject
MythContextPrivate(MythContext *lparent);
~MythContextPrivate();

bool Init (const bool gui,
const bool prompt, const bool noPrompt,
const bool ignoreDB);
bool FindDatabase(const bool prompt, const bool noPrompt);
bool Init (bool gui,
bool prompt, bool noPrompt,
bool ignoreDB);
bool FindDatabase(bool prompt, bool noPrompt);

void TempMainWindow(bool languagePrompt = true);
void EndTempWindow(void);
Expand All @@ -90,7 +90,7 @@ class MythContextPrivate : public QObject
void ResetDatabase(void);

int ChooseBackend(const QString &error);
int UPnPautoconf(const int milliSeconds = 2000);
int UPnPautoconf(int milliSeconds = 2000);
bool DefaultUPnP(QString &error);
bool UPnPconnect(const DeviceLocation *device, const QString &PIN);
void ShowGuiStartup(void);
Expand Down
2 changes: 1 addition & 1 deletion mythtv/libs/libmyth/programinfo.cpp
View file
Expand Up @@ -1017,7 +1017,7 @@ void ProgramInfo::clear(void)
* Compare two QStrings when they can either be initialized to
* "Default" or to the empty string.
*/
bool qstringEqualOrDefault(const QString a, const QString b);
bool qstringEqualOrDefault(QString a, QString b);
bool qstringEqualOrDefault(const QString a, const QString b)
{
if (a == b)
Expand Down
8 changes: 4 additions & 4 deletions mythtv/libs/libmythtv/Bluray/bdringbuffer.h
View file
Expand Up @@ -52,8 +52,8 @@ class BDOverlay
{
public:
BDOverlay() = default;
explicit BDOverlay(const bd_overlay_s * const overlay);
explicit BDOverlay(const bd_argb_overlay_s * const overlay);
explicit BDOverlay(const bd_overlay_s * overlay);
explicit BDOverlay(const bd_argb_overlay_s * overlay);

void setPalette(const BD_PG_PALETTE_ENTRY *palette);
void wipe();
Expand Down Expand Up @@ -93,8 +93,8 @@ class MTV_PUBLIC BDRingBuffer : public RingBuffer

void ClearOverlays(void);
BDOverlay* GetOverlay(void);
void SubmitOverlay(const bd_overlay_s * const overlay);
void SubmitARGBOverlay(const bd_argb_overlay_s * const overlay);
void SubmitOverlay(const bd_overlay_s * overlay);
void SubmitARGBOverlay(const bd_argb_overlay_s * overlay);

uint32_t GetNumTitles(void) const { return m_numTitles; }
int GetCurrentTitle(void);
Expand Down
2 changes: 1 addition & 1 deletion mythtv/libs/libmythtv/HLS/httplivestreambuffer.h
View file
Expand Up @@ -71,7 +71,7 @@ class HLSRingBuffer : public RingBuffer
private:
void FreeStreamsList(QList<HLSStream*> *streams) const;
HLSStream *GetStreamForSegment(int segid) const;
HLSStream *GetStream(const int wanted, const StreamsList *streams = nullptr) const;
HLSStream *GetStream(int wanted, const StreamsList *streams = nullptr) const;
HLSStream *GetFirstStream(const StreamsList *streams = nullptr) const;
HLSStream *GetLastStream(const StreamsList *streams = nullptr) const;
HLSStream *FindStream(const HLSStream *hls_new, const StreamsList *streams = nullptr) const;
Expand Down
4 changes: 2 additions & 2 deletions mythtv/libs/libmythui/cecadapter.cpp
View file
Expand Up @@ -56,9 +56,9 @@ static void CECCommandCallback(void *adapter, const cec_command* command);
static int CECAlertCallback(void *adapter, const libcec_alert alert, const libcec_parameter CEC_CALLBACK_PARAM_TYPE data);
#endif
#if CEC_LIB_VERSION_MAJOR >= 4
static void CECAlertCallback(void *adapter, const libcec_alert alert, const libcec_parameter data);
static void CECAlertCallback(void *adapter, libcec_alert alert, libcec_parameter data);
#endif
static void CECSourceActivatedCallback(void *adapter, const cec_logical_address address, const uint8_t activated);
static void CECSourceActivatedCallback(void *adapter, cec_logical_address address, uint8_t activated);
#endif

class CECAdapterPriv
Expand Down
40 changes: 20 additions & 20 deletions mythtv/programs/mythbackend/services/capture.h
View file
Expand Up @@ -51,25 +51,25 @@ class Capture : public CaptureServices
const QString &AudioDevice,
const QString &VBIDevice,
const QString &CardType,
const uint AudioRateLimit,
uint AudioRateLimit,
const QString &HostName,
const uint DVBSWFilter,
const uint DVBSatType,
uint DVBSWFilter,
uint DVBSatType,
bool DVBWaitForSeqStart,
bool SkipBTAudio,
bool DVBOnDemand,
const uint DVBDiSEqCType,
const uint FirewireSpeed,
uint DVBDiSEqCType,
uint FirewireSpeed,
const QString &FirewireModel,
const uint FirewireConnection,
const uint SignalTimeout,
const uint ChannelTimeout,
const uint DVBTuningDelay,
const uint Contrast,
const uint Brightness,
const uint Colour,
const uint Hue,
const uint DiSEqCId,
uint FirewireConnection,
uint SignalTimeout,
uint ChannelTimeout,
uint DVBTuningDelay,
uint Contrast,
uint Brightness,
uint Colour,
uint Hue,
uint DiSEqCId,
bool DVBEITScan) override; // CaptureServices

bool UpdateCaptureCard ( int CardId,
Expand All @@ -80,8 +80,8 @@ class Capture : public CaptureServices

bool RemoveCardInput ( int CardInputId) override; // CaptureServices

int AddCardInput ( const uint CardId,
const uint SourceId,
int AddCardInput ( uint CardId,
uint SourceId,
const QString &InputName,
const QString &ExternalCommand,
const QString &ChangerDevice,
Expand All @@ -91,10 +91,10 @@ class Capture : public CaptureServices
const QString &StartChan,
const QString &DisplayName,
bool DishnetEIT,
const uint RecPriority,
const uint Quicktune,
const uint SchedOrder,
const uint LiveTVOrder) override; // CaptureServices
uint RecPriority,
uint Quicktune,
uint SchedOrder,
uint LiveTVOrder) override; // CaptureServices

bool UpdateCardInput ( int CardInputId,
const QString &Setting,
Expand Down
4 changes: 2 additions & 2 deletions mythtv/programs/mythbackend/services/channel.h
View file
Expand Up @@ -122,8 +122,8 @@ class Channel : public ChannelServices
const QString &/*UserId*/,
const QString &/*Password*/ ) override; // ChannelServices

int FetchChannelsFromSource( const uint SourceId,
const uint CardId,
int FetchChannelsFromSource( uint SourceId,
uint CardId,
bool WaitForFinish ) override; // ChannelServices

/* Multiplex Methods */
Expand Down
6 changes: 3 additions & 3 deletions mythtv/programs/mythbackend/services/myth.h
View file
Expand Up @@ -60,11 +60,11 @@ class Myth : public MythServices

DTC::TimeZoneInfo* GetTimeZone ( ) override; // MythServices

QString GetFormatDate ( const QDateTime Date,
QString GetFormatDate ( QDateTime Date,
bool ShortDate ) override; // MythServices
QString GetFormatDateTime ( const QDateTime DateTime,
QString GetFormatDateTime ( QDateTime DateTime,
bool ShortDate ) override; // MythServices
QString GetFormatTime ( const QDateTime Time ) override; // MythServices
QString GetFormatTime ( QDateTime Time ) override; // MythServices
QDateTime ParseISODateString ( const QString &DateTime ) override; // MythServices

DTC::LogMessageList* GetLogs ( const QString &HostName,
Expand Down

0 comments on commit f6b0e30

Please sign in to comment.