tidy: Don't need to test a bool against 0/1 in an if statement.

The clang-tidy "implicit boolean conversion" check pointed out a couple of places where a boolean value was being explicitly compared to the number 0/1. This requires an implicit conversion to an integer to perform the check, and then an implicit conversion back to boolean to determine whether to take the if/else branch. Using the pre-existing boolean value eliminates both conversions. https://clang.llvm.org/extra/clang-tidy/checks/readability-implicit-bool-conversion.html
MythTV · Mar 26, 2019 · f759974 · f759974
1 parent c8adbdf
commit f759974
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/mythplugins/mythnetvision/mythnetvision/rsseditor.cpp b/mythplugins/mythnetvision/mythnetvision/rsseditor.cpp
@@ -105,7 +105,7 @@ bool RSSEditPopup::Create(void)
             m_thumbImage->Load();
         }
 
-        if (m_site->GetDownload() == 1)
+        if (m_site->GetDownload())
             m_download->SetCheckState(MythUIStateType::Full);
     }
 

diff --git a/mythplugins/mythnews/mythnews/mythnews.cpp b/mythplugins/mythnews/mythnews/mythnews.cpp
@@ -356,7 +356,7 @@ void MythNews::updateInfoView(MythUIButtonListItem *selected)
             if (m_thumbnailImage && m_thumbnailImage->IsVisible())
                 m_thumbnailImage->Hide();
 
-            if (m_podcastImage && site->podcast() == 1)
+            if (m_podcastImage && site->podcast())
                 m_podcastImage->Show();
 
             if (!site->imageURL().isEmpty())

diff --git a/mythplugins/mythnews/mythnews/mythnewseditor.cpp b/mythplugins/mythnews/mythnews/mythnewseditor.cpp
@@ -96,7 +96,7 @@ bool MythNewsEditor::Create(void)
         m_nameEdit->SetText(m_site->name());
         m_urlEdit->SetText(m_site->url());
         m_iconEdit->SetText(m_site->imageURL());
-        if (m_site->podcast() == 1)
+        if (m_site->podcast())
            m_podcastCheck->SetCheckState(MythUIStateType::Full);
     }
 

diff --git a/mythtv/libs/libmythtv/DVD/mythdvdplayer.cpp b/mythtv/libs/libmythtv/DVD/mythdvdplayer.cpp
@@ -670,7 +670,7 @@ void MythDVDPlayer::GoToDVDProgram(bool direction)
 {
     if (!player_ctx->m_buffer->IsDVD())
         return;
-    if (direction == 0)
+    if (direction)
         player_ctx->m_buffer->DVD()->GoToPreviousProgram();
     else
         player_ctx->m_buffer->DVD()->GoToNextProgram();

diff --git a/mythtv/programs/mythtranscode/mpeg2fix.cpp b/mythtv/programs/mythtranscode/mpeg2fix.cpp
@@ -162,7 +162,7 @@ int64_t PTSOffsetQueue::Get(int idx, AVPacket *pkt)
     {
         it = ++m_offset[idx].begin();
         if ((((*it).type == 0) && (pkt->pts >= (*it).pos_pts) /* PTS type */) ||
-            (((*it).type == 1) /* Pos type */ &&
+            (((*it).type) /* Pos type */ &&
              ((pkt->pos >= (*it).pos_pts) || (pkt->duration > (*it).framenum))))
         {
             m_offset[idx].pop_front();