Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ttvdb4.py goes asking in endless loop #473

Closed
Vollstrecker opened this issue Feb 8, 2022 · 1 comment
Closed

ttvdb4.py goes asking in endless loop #473

Vollstrecker opened this issue Feb 8, 2022 · 1 comment
Assignees
Labels
component:mythtv:metadata Metadata grabber issues version:v33-fixes fixes/33
Milestone

Comments

@Vollstrecker
Copy link

  • Platform: Debian

  • MythTV version: 31.0+fixes20220121.git4f7953f6ee

  • Package version: 31.0+fixes20220121.git4f7953f6ee-dmo2

  • Component: Metadatagrabber

What steps will reproduce the bug?

Hi,

as mentioned before, when the grabber is unsure and asks which match to use, this ends in an endless-loop. Example: Die Nanny S6E15, the Episode is called Die glücklichste Fran der Welt (1), Episode 16 has the same name but ending on (2). It seems that somewhere this number get's swallowed.

Log:
2022-02-08 20:51:23.654007 I Running Grabber: /usr/share/mythtv/metadata/Television/ttvdb4.py -l de -a DE -N Die Nanny Die Glücklichste Fran Der Welt (1)
2022-02-08 20:53:10.428927 I Result Found, Season 6 Episode 15
2022-02-08 20:53:10.429168 I Result Found, Season 6 Episode 16
2022-02-08 20:53:10.680131 I Running Grabber: /usr/share/mythtv/metadata/Movie/tmdb3.py -l de -a DE -M Die Nanny
2022-02-08 20:53:10.880690 I Result Found, Season 6 Episode 15
2022-02-08 20:53:10.880732 I Returning Metadata Results: Die Nanny 6 15

<<<<<<<<<<< Here it asks for selecting the right match, then: >>>>>>>>>>>>>

2022-02-08 20:54:08.170183 I Manual Metadata Lookup: Selected Item: Type: Video : Subtype: Television : InetRef: ttvdb4.py_75675
2022-02-08 20:54:09.384330 I Running Grabber: /usr/share/mythtv/metadata/Television/ttvdb4.py -l de -a DE -N 75675 Die glücklichste Fran der Welt (1)
2022-02-08 20:54:10.139440 I Result Found, Season 6 Episode 15
2022-02-08 20:54:10.139713 I Result Found, Season 6 Episode 16
2022-02-08 20:54:10.140085 I Running Grabber: /usr/share/mythtv/metadata/Television/ttvdb4.py -l de -a DE -D 75675
2022-02-08 20:54:10.288642 I Returning Metadata Results: Die Nanny 6 15

This goes over and over again until I cancel the selection with getting any data.

How often does it reproduce? Is there a required condition?

It does it always, Condition is any title that returns more than one match.

What is the expected behaviour?

After the selection, the selected data should be retrieved. When adding season and episode to the request, it would work.

What do you see instead?

By now? Adding them directly into the database - by hand.

rcrdnalor added a commit that referenced this issue Feb 9, 2022
over subtitle search if inetref is provided.

The search for TV shows with 'inetref' & 'subtitle' is ambiguous if the
same subtitle exists multiple times, like "Episode 1" available for
multiple seasons.

If data for 'season' and 'episode' numbers are available, use it at
first instance, because these data are unique.

Refs #473
rcrdnalor added a commit that referenced this issue Feb 9, 2022
over subtitle search if inetref is provided.

The search for TV shows with 'inetref' & 'subtitle' is ambiguous if the
same subtitle exists multiple times, like "Episode 1" available for
multiple seasons.

If data for 'season' and 'episode' numbers are available, use it at
first instance, because these data are unique.

Refs #473

(cherry picked from commit 2311368)
@rcrdnalor rcrdnalor self-assigned this Feb 9, 2022
@rcrdnalor rcrdnalor added the component:mythtv:metadata Metadata grabber issues label Feb 9, 2022
@rcrdnalor rcrdnalor modified the milestones: 31.1, 32.0 Feb 9, 2022
@rcrdnalor rcrdnalor added the version:v33-fixes fixes/33 label Feb 9, 2022
rcrdnalor added a commit that referenced this issue Feb 19, 2022
over subtitle search if inetref is provided.

The search for TV shows with 'inetref' & 'subtitle' is ambiguous if the
same subtitle exists multiple times, like "Episode 1" available for
multiple seasons.

If data for 'season' and 'episode' numbers are available, use it at
first instance, because these data are unique.

Refs #473

(cherry picked from commit 2311368)
@rcrdnalor
Copy link
Contributor

Back-ported to fixes/31 by commit ce31be6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:mythtv:metadata Metadata grabber issues version:v33-fixes fixes/33
Projects
None yet
Development

No branches or pull requests

2 participants