Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time format messed up on LCD #579

Closed
Mark-Clegg opened this issue Jun 4, 2022 · 1 comment
Closed

Time format messed up on LCD #579

Mark-Clegg opened this issue Jun 4, 2022 · 1 comment

Comments

@Mark-Clegg
Copy link

Mark-Clegg commented Jun 4, 2022

  • Platform: AMD64

  • Linux nostromo 5.18.1-arch1-1 Added fix for Ticket 8182 #1 SMP PREEMPT_DYNAMIC Mon, 30 May 2022 17:53:11 +0000 x86_64 GNU/Linux

  • MythTV version: 32/fixes

  • Package version: Arch linux AUR package

  • Component: mythlcdserver

What steps will reproduce the bug?

Start myth, observe time on LCD display

On the LCD the time is alternatly displayed as "hh:mm" and "hhmm",

How often does it reproduce? Is there a required condition?

always

What is the expected behaviour?

time should alternate between "hh:mm" and "hh mm" (note the space replacing the colon) to give the illusion of a blinking colon.

What do you see instead?

Additional information

suggested fix:

--- package.orig/mythtv/mythtv/programs/mythlcdserver/lcdprocclient.cpp 2022-06-04 15:30:09.000000000 +0100
+++ package.new/mythtv/mythtv/programs/mythlcdserver/lcdprocclient.cpp  2022-06-04 15:33:30.591887745 +0100
@@ -1891,7 +1891,7 @@
         aString += time + "\"";
         if ( m_timeFlash )
         {
-            aString = aString.remove(":");
+            aString = aString.replace(':',' ');
             m_timeFlash = false;
         }
         else
@twitham1
Copy link
Contributor

Yes, I got this odd moving time on the LCD at v32 upgrade. Appears to be from 2bc6c31 and your fix here should work well.

twitham1 added a commit to twitham1/mythtv that referenced this issue Jun 25, 2022
twitham1 added a commit to twitham1/mythtv that referenced this issue Jun 25, 2022
kmdewaal pushed a commit that referenced this issue Jun 25, 2022
twitham1 added a commit to twitham1/mythtv that referenced this issue Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants