Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skipping to previous commercial the negative dash shows in front of both the minutes and seconds (-03:-03) #733

Closed
brfransen opened this issue Mar 17, 2023 · 2 comments
Closed

Skipping to previous commercial the negative dash shows in front of both the minutes and seconds (-03:-03) #733

brfransen opened this issue Mar 17, 2023 · 2 comments
Assignees
@kmdewaal

Comments

@brfransen
Copy link
Contributor

  • Platform: Arch Linux

  • MythTV version: v33.1-7f288be6

  • Component: Playback

What steps will reproduce the bug?

Playback a recording jump forward a couple commercial breaks (default Q key), then jump back a few commercial breaks (default Z key). When jumping back the OSD show the dash in front of both the minutes and seconds (-03:-03)

What do you see instead?

The OSD should only show the negative in front of the minutes. (-03:03)
@kmdewaal
Copy link
Contributor

The issue can be easily reproduced. The formatting route does not correctly handle negative values for the number of milliseconds skipped. This can be easily fixed by first determining the sign, then doing the conversion to string and then prepending the minus sign if needed. A fix is forthcoming.

@kmdewaal kmdewaal self-assigned this Mar 17, 2023
kmdewaal added a commit that referenced this issue Mar 17, 2023
@kmdewaal
Conversion of negative time values to string
c166849 
When converting a negative time value with format string "m:ss" there is
a minus sign before the minutes and also a minus sign before the seconds.
The implementation apparently only supports positive time interval values.
The implementation is now extended to support negative time interval values
by converting the absolute time value to string and then prepending a minus
sign when the time value is negative.
The implementation was introduced in commit 65b9c73
"Better fix for MythDate::formatTime to handle overflows.", committed on Mar 16, 2022.

Refs #733
kmdewaal added a commit that referenced this issue Mar 24, 2023
@kmdewaal
Conversion of negative time values to string
b391cfb 
When converting a negative time value with format string "m:ss" there is
a minus sign before the minutes and also a minus sign before the seconds.
The implementation apparently only supports positive time interval values.
The implementation is now extended to support negative time interval values
by converting the absolute time value to string and then prepending a minus
sign when the time value is negative.
The implementation was introduced in commit 65b9c73
"Better fix for MythDate::formatTime to handle overflows.", committed on Mar 16, 2022.

Refs #733

(cherry picked from commit c166849)
@kmdewaal
Copy link
Contributor

Fixed now in master and in fixes/33. Closing this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kmdewaal kmdewaal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brfransen @kmdewaal