Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of mythuiwebbrowser.h bits in mythmusic optional #334

Merged
merged 1 commit into from Apr 2, 2021

Conversation

ijc
Copy link
Contributor

@ijc ijc commented Mar 13, 2021

If qtwebkit (and therefore mythuiwebbrowser) are not available then omit the menu items relating to searching for artwork on the internet.

Fixes #328 (or at least, worksaround I suppose)


Checklist

@stuarta stuarta linked an issue Mar 15, 2021 that may be closed by this pull request
@ijc ijc force-pushed the less-webkit-in-mythmusic branch from b272de8 to 26b589a Compare March 27, 2021 14:57
@ijc ijc changed the title Remove unused mythuiwebbrowser.h bits from mythmusic Make use of mythuiwebbrowser.h bits in mythmusic optional Mar 27, 2021
@ijc
Copy link
Contributor Author

ijc commented Mar 30, 2021

Looks like I need to rebase onto c37fc10. I'll try and do that over the Easter break, it doesn't look too complex.

(@linuxdude42 FYI)

It is used only to search for various types of art work, so if it is not
available we simply build without it.
@ijc ijc force-pushed the less-webkit-in-mythmusic branch from 26b589a to 570e9dc Compare April 2, 2021 15:07
@ijc
Copy link
Contributor Author

ijc commented Apr 2, 2021

Rebased.

@linuxdude42
Copy link
Contributor

Thanks.

@linuxdude42 linuxdude42 merged commit fc25c42 into MythTV:master Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QtWebKit deprecated: MythMusic plugin
2 participants