Performance improvements for mythtv-setup "Fetch channels from listing source" #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performing an allatonce grab can result in a grabber obtaining and producing a large amount of data which can take a long time and/or use a lot of resouces. Since --only-update-channels is specified to obtain as little data as possible in order to update the channels, fall back to a single day grab even for grabbers that prefer allatonce.
…nnels Grabbers that support --list-channels will return just the channel data, and may not use resources to obtain and/or format program data. It is a good fit for an --only-update-channels request when available. Some grabbers that do not support --list-channels may perform equivalently with a --days 0 grab request, but --days 0 is not in spec, and is rejected by some grabbers, so we cannot use that as an alternative.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to MythTV!
Please review the checklist below to ensure that your contribution
to MythTV is ready for review by our developers.
It is helpful to regularly rebase your pull request to ensure changes
apply cleanly to the current MythTV development branch.
Checklist
This pull request is related to issue #412