libmythfreesuround cleanup (remove internal FFmpeg header fft.h) #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use array access instead of iterators and combine loops
m_dft[RL] seem to be twice as big as necessary, but I kept the size for no functional change. Strict aliasing fixes. av_fft_init with 13 is only correct since the block size is always 8192. FFmpeg free()s the context in av_fft_end
also improve readability
…_mag This more clearly expresses what the function does and avoids confusion with std::clamp.
|
This compiles with/without libfftw3 being present on my system. Unfortunately the only place I can test it is on my production frontend... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally part of #416 . However, it stands on its own, so I have split it off.
This is motivated by #428 enable use of system FFmpeg.
Note: for testing most of the changes,
./configure --disable-fftw3Checklist