New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace configure's ARCH... with Q_PROCESSOR_... v2 #487
Conversation
QtGlobal replaces mythconfig.h
QtGlobal replaces mythconfig.h
with 16 registers, instead of the original 8 for the x86 extension. I have not investigated whether or not the extra registers are used.
It's only used once, so it could be a function static.
Q_PROCESSOR_ARM_64 is undocumented, but has existed since 2013, so I have duplicated the checks for GCC/clang and MSVC.
This should be equivalent to the check from configure. x86_64 assumes <emmintrin.h> exists; however, I'm not sure if it would also be acceptable to assume <arm_neon.h> exists when compiling for ARM.
Commit 93de0f8 with the HAVE_INTRINSICS_NEON change is causing build failures on an rpi3. I'm seeing the following errors:
This change doesn't have the additional compilation test that configure does on line 5568, which is apparently necessary. |
And was first reported failed by the armv7 buildbot worker on irc on 2022-02-18. |
The builder @garybuhrmaster referenced uses GCC may want The used intrinsic is valid: https://developer.arm.com/architectures/instruction-sets/intrinsics/#q=vrhaddq_u16 |
Was in #470
Separated from other changes.
HAVE_INTRINSICS_NEON
mythtv/mythtv/configure
Line 5568 in 8cbe838