Base watch list ordering on series most recently warched or recorded #540
Conversation
| MythDate::as_utc(query.value(4).toDateTime()); | ||
| QDateTime last_record = | ||
| MythDate::as_utc(query.value(5).toDateTime()); | ||
|
|
||
| QDateTime last_delete = | ||
| MythDate::as_utc(query.value(6).toDateTime()); |
There was a problem hiding this comment.
Since you aren't using the other values any more I think you could simplify the SQL now to just SELECT recordid, last_delete FROM record; and this would become value(1).
There was a problem hiding this comment.
Oh! Good point. I will sort that out.
There was a problem hiding this comment.
Okay. I've simplified the SQL, as you suggested.
|
I've applied this patch to my frontend and it produces more sensible looking watch lists to me. At the least it is now choosing the first season/episode by airdate rather than recording date. When I watched a few seconds of a thing it bumped up the list. I think the proposed logic/simplification makes sense. If nothing else it seems like a much better base for future refinement to me (in so far as it's much easier to figure out what it actually does...). Apart from the opportunity for simplifying the SQL I mentioned above the code looks fine to me (FWIW). |
(Also fixes the problme of air date taking priority over series and episode) Before this change, the watch list used a complex ordering that was designed to help users keep up to date with many series simultaneosly, ensuring that they didn't get behind with some. It's cleverly designed, but seems very specific to the author's particular viewing habits. It doesn't account well for shows that you really don't want to watch just now, but you think you might one day. Nor does it account for a wish to wait for a whole series before binging. This commit simplifies the design, taking the view that mostly the user will want to continue with series that they've recently viewed, or to which a new recording has recently been added. The new ordering gives the user more control: if you wish to make a series appear higher in the watch list then just watch a few seconds of an episode; if you wish to make a series appear lower then don't watch any episodes from it and it will get pushed out by the series you are watching.
Glidos
force-pushed
the
simplify-watch-list-priority-master
branch
from
b0afca5
to
9ae7126
Compare
Previously the option was avaialable only when using the "All programs" group, although it is useful also from the watch list.
|
I've just added one more commit to this pull request: it makes "List Recorded Episodes" available from the watch list. |
(Also fixes the problem, when determining which episode to display, of air
date taking priority over series and episode)
Before this change, the watch list used a complex ordering that was
designed to help users keep up to date with many series simultaneosly,
ensuring that they didn't get behind with some. It's cleverly designed,
but seems very specific to the author's particular viewing habits. It
doesn't account well for shows that you really don't want to watch just
now, but you think you might one day. Nor does it account for a wish to
wait for a whole series before binging.
This commit simplifies the design, taking the view that mostly the user
will want to continue with series that they've recently viewed, or one to
which a new recording has recently been added. The new ordering gives the
user more control: if you wish to make a series appear higher in the watch
list then just watch a few seconds of an episode; if you wish to make a
series appear lower then don't watch any episodes from it and it will
get pushed out by the series you are watching.