Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix big endian linking issues #685

Closed
wants to merge 1 commit into from

Conversation

KungFuJesus
Copy link

This code would compile but due to the way C++ handles templated types, it would look for this inlined routine to be exported at link time since the only templated types defined are Qt flavored integers.

Ideally this is generating single instruction byteswaps similar to what happens when you use compiler builtins but admittedly I never checked.

Checklist

This code would compile but due to the way C++ handles templated types,
it would look for this inlined routine to be exported at link time since
the only templated types defined are Qt flavored integers.

Ideally this is generating single instruction byteswaps similar to what
happens when you use compiler builtins but admittedly I never checked.
@kmdewaal
Copy link
Contributor

I do appreciate the effort spent in fixing this, but it looks like this has already been fixed in master in commit 8960641 on March 23. Considering that it apparently also needs fixing in version 32, I think it is best to cherry-pick that commit into version 32.

@KungFuJesus
Copy link
Author

Works for me

@kmdewaal
Copy link
Contributor

Fixed with commit cb65c93 .

@kmdewaal kmdewaal closed this Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants