UPnP - Fix broken FFWD/REW/JUMP in playback for recordings with startoffset #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts for recordings with startoffset This fixes error with playback navigation through FFWD/REW buttons and navigation bar in some LG SmartTV DLNA clients. The patch replaces dtProgStart by dtStartTime in the query to recordedmarkup table. If startoffset for a recording is nonzero, dtProgStart by dtStartTime differ and the query fails. As fallback, the duration attribute for <res/> tag is filled by the value from EIT data, which may differ from the actual length of playback. The DLNA client concerned unfortunately relies on duration attribute for playback navigation, so the playback navigation is completely broken.
|
Ticket in TRAC : https://code.mythtv.org/trac/ticket/12187#ticket |
|
Fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to propose this simple fix that affects some LG SmartTV DLNA clients. I think it can be applied to current stable branch as bugfix and definitely to the master branch. This fixes error in playback navigation through FFWD/REW buttons and through the navigation bar. The patch replaces dtProgStart by dtStartTime in the query into recordedmarkup table.
Without this patch, and if the recording is recorded with non-zero startoffset, dtProgStart differ from dtStartTime and the query fails. Correct playback duration is not found and asfallback, the duration attribute for tag is filled by the value from EIT data, which may differ from the actual length of playback. The DLNA client concerned, unfortunately relies on duration attribute, and the playback navigation is then completely broken.
If the patch is applied, the correct playback duration is send to the DLNA client and it works without problems.
These are clients affected : LG SmartTV series 2012, probably also other series that share the same code, 2011 and 2013. Windows Media Player is not affected.
Symptoms : If you Jump forward (with FFWD button) or jump backward (with RWND button) or you navigate through the recording using the navigation bar, the playback jumps to the position that seems not to be related to where you intended to jump. Sometimes forward jump might go backwards and vice versa. It is quite frustrating. Consequently, WAF is completely ruined.
I have tested this well with current stable build from mythbuntu distribution 2:0.27.1+fixes.20140612.050bf9d.