Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
check for
http_proxy
& https_proxy
env-vars
this brings us in line with many other AWS SDKs which check for this environment variable, and properly set it. a couple things to note about this: 1. I chose to not add in explicit unit tests/integration tests as the webproxy already has tests. and testing an environment variable would bleed into other tests unless we mocked it everywhere, or we serially ran those tests that depended on the state of the env var. I think the overhead of either of these is not worth what we get out of it (which is effectively two calls to BCL, one for the environment variable, one for constructing a web proxy). if you want me to go through either of these paths, i can. 2. HTTPS proxies were only recently supported in dotnet: <dotnet/runtime#31113>. I chose to 'try to construct, error if it fails'. This techincally introduces a case where you get an exception being thrown you wouldn't before. This _feels_ like the right path "hey your https proxy isn't being used even though you told us to use it". I can wrap this in a try catch block though if we decide we just want to silently ignore it like we have been so far (this may lead to more bugs being filed about "why doesn't https_proxy work!").
- Loading branch information