You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#112 moved all black/isort/flake8/mypy configurations from pyproject.toml to pre-commit-config.yaml. Because of this, the linters and formatters in my text editor can no longer find the ALNS-specific configurations and resort to the default configuration settings (e.g., 88 line length for black). This makes the development process painful because my commits are formatted differently on-save than what we specified in pre-commit.
When I look at the repositories from mypy, isort and black, they have their configuration settings in pyproject.toml or setup.cfg and not in pre-commit-config.yaml. Pre-commit can still infer the configuration settings from these files. So I propose to put the config back to pyproject.toml (and possibly setup.cfg), at least to get linting/formatting in my editor working again. I suspect most editors will have the same problem if they have some of the above linting/formatting tools installed, but I haven't tested that.
#112 moved all black/isort/flake8/mypy configurations from
pyproject.toml
topre-commit-config.yaml
. Because of this, the linters and formatters in my text editor can no longer find the ALNS-specific configurations and resort to the default configuration settings (e.g., 88 line length for black). This makes the development process painful because my commits are formatted differently on-save than what we specified in pre-commit.When I look at the repositories from mypy, isort and black, they have their configuration settings in
pyproject.toml
orsetup.cfg
and not inpre-commit-config.yaml
. Pre-commit can still infer the configuration settings from these files. So I propose to put the config back topyproject.toml
(and possiblysetup.cfg
), at least to get linting/formatting in my editor working again. I suspect most editors will have the same problem if they have some of the above linting/formatting tools installed, but I haven't tested that.@N-Wouda What do you think?
The text was updated successfully, but these errors were encountered: