-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pre-commit + isort #112
Conversation
Codecov Report
@@ Coverage Diff @@
## master #112 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 28 28
Lines 664 664
=========================================
Hits 664 664
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
If we move all dev stuff into pre-commit, can we then get rid of the dev dependencies in |
Then we can probably also get rid of a lot of the settings in pyproject.toml. |
I read somewhere that testing is not recommended to be part of pre-commit. I guess that's mainly in very large codebases, which have much longer tests than we do have here. I think it's fine if we do add pytest to pre-commit. So yes, we can put everything in pre-commit. |
I meant just the linting and static type checker stuff. The test and coverage stuff can stay, I think. |
Much better! |
Closes #90.