-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example notebook PFSP #110
Conversation
This is almost done. I'll have another read tomorrow morning and then this can be reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll have a look at the notebook now.
Notebook:
Or:
And then mention
What happens if you use 0.01 or 0.05 for |
This LGTM, and I think most of what I remark on above can be updated really quickly. |
@N-Wouda I addressed all comments in the latest version! Can you merge this if you're OK with this? |
Yeah, I think it's OK now. I fixed two small typo's. |
This is a very nice addition to the examples. We have a wide range of examples now, which should help people get started quickly. |
Closes #106.