Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github templates, contributing text #115

Merged
merged 7 commits into from
Nov 16, 2022
Merged

Github templates, contributing text #115

merged 7 commits into from
Nov 16, 2022

Conversation

N-Wouda
Copy link
Owner

@N-Wouda N-Wouda commented Nov 16, 2022

@N-Wouda N-Wouda requested a review from leonlan November 16, 2022 13:53
@N-Wouda
Copy link
Owner Author

N-Wouda commented Nov 16, 2022

@leonlan I've largely based this on how statsmodels does this. This default should be good enough for us for now.

@codecov
Copy link

codecov bot commented Nov 16, 2022 •
edited

Codecov Report

Merging #115 (e120027) into master (fd0c9e1) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #115   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           28        28           
  Lines          664       665    +1     
=========================================
+ Hits           664       665    +1
Impacted Files Coverage Δ
alns/__init__.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

leonlan
leonlan approved these changes Nov 16, 2022
View reviewed changes
Copy link
Collaborator

@leonlan leonlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@N-Wouda N-Wouda merged commit a1d5a4b into master Nov 16, 2022
@N-Wouda N-Wouda deleted the templates-and-how-to-contribute-files branch November 16, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonlan leonlan leonlan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code of conduct, how to contribute, templates
2 participants
@N-Wouda @leonlan