Updating inputs for MABSelector to new types LearningPolicyType and NeighboorhoodPolicyType from the new version of mabwiser #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eighboorhoodPolicyType
Codecov Report
@@ Coverage Diff @@
## master #162 +/- ##
=======================================
Coverage 99.46% 99.46%
=======================================
Files 30 30
Lines 747 747
=======================================
Hits 743 743
Misses 4 4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
N-Wouda
approved these changes
Aug 3, 2023
There was a problem hiding this comment.
Hi @AshishPvjs, thanks for the PR! Looks good to me, except for the one issue with the types. I'll commit that and then merge this in.
skadio
reviewed
Aug 3, 2023
|
Thank you @N-Wouda. |
|
thank you as well @AshishPvjs --also for making the change in MABWiser side |
|
New release is underway: https://github.com/N-Wouda/ALNS/actions/runs/5755818928. Should hit PyPI in a few minutes! 🚀 |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.