-
Notifications
You must be signed in to change notification settings - Fork 20
Conversation
- Add Checkstyle action on PR (closes #38)
Believe me, you want to leave out |
Based on GitHub Docs the issue and PR template files may not be recognized correctly. For example, valid path names for the PR template seem to be:
I think we should redo the renaming of the template files. |
I will add some more changes based on this document and I would really appreciate if you comment on them later on again, too. This way, we come to a solution together :) |
…access Additionally removed the quotation marks, they are not enforced by YAML.
Looks like we will have a lot of cleaning work to do if we really want to get a 'good' code base. Reviewdog reports:
|
The previous setting was restricted to pushes or pull requests to the main branch. Furthermore, 'workflow_dispatch' has been removed.
We should also discuss about the setting of the |
:monkaGiga: |
First of all sory for fucking up the template location and configuration. As far as I care, at least the line length case can be, either commented out or removed completely. We are creating sometimes large arrays with specific values as test algortithms would present a solution. Failing on Error sounds like a good idea. Having Tests that dont compile does not sound reasonable to me. We might also unify the names for the actions. I think there are 2/3 different names in the config. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would be fine with this settings now. Fine grained tuning can be done later on, too. Any other suggestions or comments on that? @N0W0RK
Structure changes in .github.
Added GithubAction for CI using checkstyle with the Artemis configuration (closes #38)